Skip to content

handle concurrent uploads #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnterickson wants to merge 3 commits into
base: main
Choose a base branch
from
Open

handle concurrent uploads #137

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a774b8f
handle concurrent uploads
johnterickson Jul 7, 2025
93838c7
supress code analysis
johnterickson Jul 7, 2025
c6877d8
Align impls better.
johnterickson Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 31 additions & 10 deletions src/AzurePipelines/PipelineCachingCacheClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,12 +292,22 @@ protected override async Task AddNodeAsync(
result.ProofNodes,
ContentFormatConstants.Files);

CreateResult createResult = await WithHttpRetries(
() => _cacheClient.CreatePipelineCacheArtifactAsync(entry, null, cancellationToken),
await WithHttpRetries(
async () =>
{
try
{
CreateResult createResult = await _cacheClient.CreatePipelineCacheArtifactAsync(entry, null, cancellationToken);
Tracer.Debug(context, $"Cache entry for {fingerprint} stored in scope `{createResult.ScopeUsed}`");
}
catch (PipelineCacheItemAlreadyExistsException)
{
Tracer.Debug(context, $"Cache entry for {fingerprint} already exists.");
}
},
cacheContext: context,
message: $"Storing cache key for {fingerprint}",
cancellationToken);
Tracer.Debug(context, $"Cache entry stored in scope `{createResult.ScopeUsed}`");
}
finally
{
Expand Down Expand Up @@ -730,16 +740,27 @@ private string ComputeSelectorsKey(BuildXL.Cache.MemoizationStore.Interfaces.Ses
cancellationToken);
}

private Task WithHttpRetries(Func<Task> taskFactory, Context cacheContext, string message, CancellationToken token)
=> WithHttpRetries(
async () =>
{
await taskFactory();
return 0; // we don't care about the result, just that it succeeded
},
cacheContext,
message,
token);

private Task<T> WithHttpRetries<T>(Func<Task<T>> taskFactory, Context cacheContext, string message, CancellationToken token)
{
return AsyncHttpRetryHelper<T>.InvokeAsync(
taskFactory,
maxRetries: 10,
tracer: _azureDevopsTracer,
canRetryDelegate: _ => true, // retry on any exception
cancellationToken: token,
continueOnCapturedContext: false,
context: EmbedCacheContext(cacheContext, message));
taskFactory,
maxRetries: 10,
tracer: _azureDevopsTracer,
canRetryDelegate: _ => true, // retry on any exception
cancellationToken: token,
continueOnCapturedContext: false,
context: EmbedCacheContext(cacheContext, message));
}

public override async ValueTask DisposeAsync()
Expand Down
Loading