Skip to content

adopt governed template in release pipeline #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JanProvaznik merged 1 commit into from
Jan 5, 2026
Merged

adopt governed template in release pipeline #372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
130 changes: 69 additions & 61 deletions release-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,76 +6,84 @@ resources:
source: microsoft.MSBuildLocator
trigger:
enabled: false
repositories:
- repository: 1ESPipelineTemplates
type: git
name: 1ESPipelineTemplates/1ESPipelineTemplates
ref: refs/tags/release

variables:
SymbolsFeatureName: 'MSBuild'
SymbolsProject: 'DDE'
TeamName: 'msbuild'
VstsDropNames: 'Products/DevDiv/Microsoft/msbuild/$(Build.SourceBranchName)/$(Build.BuildNumber)/$(Build.BuildId)'

stages:
- stage: RetainBuild
displayName: 'Retain build'
jobs:
- job: RetainBuildJob
displayName: 'Run on agent'
extends:
template: v1/1ES.Official.PipelineTemplate.yml@1ESPipelineTemplates
parameters:
settings:
networkIsolationPolicy: Permissive,CFSClean
pool:
name: 'VSEngSS-MicroBuild2022-1ES'
steps:
- download: microsoft_MSBuildLocator
displayName: 'Download Symbols Artifact'
artifact: Symbols
name: VSEngSS-MicroBuild2022-1ES
Copy link

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace detected at the end of this line. This should be removed to maintain consistent formatting.

Suggested change
name: VSEngSS-MicroBuild2022-1ES
name: VSEngSS-MicroBuild2022-1ES

Copilot uses AI. Check for mistakes.
stages:
- stage: RetainBuild
displayName: 'Retain build'
jobs:
- job: RetainBuildJob
displayName: 'Run on agent'
steps:
- download: microsoft_MSBuildLocator
displayName: 'Download Symbols Artifact'
artifact: Symbols

- task: MicroBuildArchiveSymbols@6
displayName: 'Archive $(SymbolsFeatureName) on Symweb'
inputs:
SymbolsFeatureName: '$(SymbolsFeatureName)'
SymbolsProject: '$(SymbolsProject)'
SymbolsAgentPath: '$(Pipeline.Workspace)/microsoft_MSBuildLocator/Symbols'
SubmitToInternet: true
ExpirationInDays: '5475'
azureSubscription: 'VSEng-SymbolsUpload'
env:
SYSTEM_ACCESSTOKEN: $(System.AccessToken)
- task: MicroBuildArchiveSymbols@6
displayName: 'Archive $(SymbolsFeatureName) on Symweb'
inputs:
SymbolsFeatureName: '$(SymbolsFeatureName)'
SymbolsProject: '$(SymbolsProject)'
SymbolsAgentPath: '$(Pipeline.Workspace)/microsoft_MSBuildLocator/Symbols'
SubmitToInternet: true
ExpirationInDays: '5475'
azureSubscription: 'VSEng-SymbolsUpload'
env:
SYSTEM_ACCESSTOKEN: $(System.AccessToken)

- task: MicroBuildRetainVstsDrops@1
displayName: 'Retain VSTS Drops'
enabled: false
inputs:
DropNames: '$(VstsDropNames)'
DropServiceUri: 'https://devdiv.artifacts.visualstudio.com/DefaultCollection'
- task: MicroBuildRetainVstsDrops@1
displayName: 'Retain VSTS Drops'
enabled: false
inputs:
DropNames: '$(VstsDropNames)'
DropServiceUri: 'https://devdiv.artifacts.visualstudio.com/DefaultCollection'

- stage: PublicRelease
displayName: 'Public release'
dependsOn: RetainBuild
condition: succeeded()
jobs:
- job: PushToNuGet
displayName: 'Push to nuget.org'
pool:
name: 'VSEngSS-MicroBuild2022-1ES'
steps:
- download: microsoft_MSBuildLocator
displayName: 'Download NuGet Package Artifact'
artifact: pkg
- task: NuGetCommand@2
displayName: 'NuGet push'
inputs:
command: 'push'
packagesToPush: '$(Pipeline.Workspace)/microsoft_MSBuildLocator/pkg/Microsoft.Build.Locator*.nupkg'
nuGetFeedType: 'external'
publishFeedCredentials: 'MSBuild-Locator'
verbosityPush: 'Detailed'
- stage: PublicRelease
displayName: 'Public release'
dependsOn: RetainBuild
condition: succeeded()
jobs:
- job: PushToNuGet
displayName: 'Push to nuget.org'
steps:
Comment on lines +63 to +65
Copy link

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pool specification has been removed from the PushToNuGet job. While a default pool is configured at the template level (line 26-27), verify that this job should use the default pool rather than having an explicit pool specification. The RetainBuildJob and PublicNuGetRelease jobs previously used the same pool, but PushToNuGet had its own pool definition that is now removed.

Copilot uses AI. Check for mistakes.
- download: microsoft_MSBuildLocator
displayName: 'Download NuGet Package Artifact'
artifact: pkg
- task: NuGetCommand@2
displayName: 'NuGet push'
inputs:
command: 'push'
packagesToPush: '$(Pipeline.Workspace)/microsoft_MSBuildLocator/pkg/Microsoft.Build.Locator*.nupkg'
nuGetFeedType: 'external'
publishFeedCredentials: 'MSBuild-Locator'
verbosityPush: 'Detailed'

- job: PublicNuGetRelease
displayName: 'Public NuGet release'
dependsOn: PushToNuGet
pool: server
steps:
- task: ManualValidation@0
displayName: 'Push packages to NuGet'
inputs:
instructions: |
https://microsoft.sharepoint.com/teams/toolsforeng/_layouts/OneNote.aspx?id=%2Fteams%2Ftoolsforeng%2FOne%20Note%2FToolsForSoftwareEngineers&wd=target%28Build%20Tools%2FMSBuild%2FGitHub.one%7CFF6DC598-65EC-43D5-AB29-DB38FEB82BC8%2FMyGet%20Feed%7CFAFC6258-899D-48D4-8DB4-892396202C9C%2F%29
onenote:https://microsoft.sharepoint.com/teams/toolsforeng/One%20Note/ToolsForSoftwareEngineers/Build%20Tools/MSBuild/GitHub.one#MyGet%20Feed&section-id={FF6DC598-65EC-43D5-AB29-DB38FEB82BC8}&page-id={FAFC6258-89
onTimeout: 'reject'
- job: PublicNuGetRelease
displayName: 'Public NuGet release'
dependsOn: PushToNuGet
pool: server
steps:
- task: ManualValidation@0
displayName: 'Push packages to NuGet'
inputs:
instructions: |
https://microsoft.sharepoint.com/teams/toolsforeng/_layouts/OneNote.aspx?id=%2Fteams%2Ftoolsforeng%2FOne%20Note%2FToolsForSoftwareEngineers&wd=target%28Build%20Tools%2FMSBuild%2FGitHub.one%7CFF6DC598-65EC-43D5-AB29-DB38FEB82BC8%2FMyGet%20Feed%7CFAFC6258-899D-48D4-8DB4-892396202C9C%2F%29
onenote:https://microsoft.sharepoint.com/teams/toolsforeng/One%20Note/ToolsForSoftwareEngineers/Build%20Tools/MSBuild/GitHub.one#MyGet%20Feed&section-id={FF6DC598-65EC-43D5-AB29-DB38FEB82BC8}&page-id={FAFC6258-89
onTimeout: 'reject'
Loading