Skip to content

Commit 6c31b9a

Browse files
author
David Kline
authored
Merge pull request #6749 from keveleigh/docs
Update recommended version for new MRC and header update
2 parents 9ba100b + 49254d0 commit 6c31b9a

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

Assets/MixedRealityToolkit.Providers/WindowsMixedReality/Editor/WindowsMixedRealityCameraSettingsProfileInspector.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public override void OnInspectorGUI()
4343
InspectorUIUtility.RenderDocumentationButton(MRCDocURL);
4444
}
4545

46-
EditorGUILayout.HelpBox("Render from PV Camera is supported on Unity 2018.4.12f1 or newer and 2019.3 or newer. Enabling the feature on other versions may result in incorrect capture behavior.", MessageType.Info);
46+
EditorGUILayout.HelpBox("Render from PV Camera is supported on Unity 2018.4.13f1 or newer and 2019.3 or newer. Enabling the feature on other versions may result in incorrect capture behavior.", MessageType.Info);
4747

4848
EditorGUILayout.PropertyField(renderFromPVCameraForMixedRealityCapture, pvCameraRenderingTitle);
4949

Documentation/Contributing/CONTRIBUTING.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ If you have any questions, please reach out on the [mixed-reality-toolkit channe
66
You can join the Slack community via the [automatic invitation sender](https://holodevelopersslack.azurewebsites.net/).
77

88
## Submission process
9+
910
We provide several paths to enable developers to contribute to the Mixed Reality Toolkit, all starting with [creating a new Issue](https://github.com/Microsoft/MixedRealityToolkit-Unity/issues/new/choose).
1011

1112
<img src="../Images/Contributing/SelectIssueType.png" width="600">
@@ -17,6 +18,7 @@ From here you file:
1718
- **Feature request** - Proposal for a new Mixed Reality Toolkit feature
1819

1920
## Proposing Feature Requests
21+
2022
When requesting a new Mixed Reality Toolkit feature, it is important to document the customer benefit / problem to be solved. Once submitted, a feature request will be reviewed and discussed on GitHub. We encourage open and constructive discussion of each feature proposal to ensure that the work is beneficial to a large segment of customers.
2123

2224
To avoid needing to rework the feature, it is generally recommended that development of the feature does not begin during the review phase. Many times, the community review process uncovers one or more issues that may require significant changes in the proposed implementation.
@@ -42,4 +44,3 @@ When adding a bug fix or feature, follow these steps:
4244
1. Ensure the code and feature(s) are documented as described in the [Documentation Guidelines](DocumentationGuide.md).
4345
1. Ensure the code works as intended on all platforms. Please see [Release notes](../ReleaseNotes.md) for the list of supported platforms. For Windows UWP projects, code must be [WACK compliant](https://developer.microsoft.com/en-us/windows/develop/app-certification-kit). To do this, generate a Visual Studio solution, right click on project; **Store** > **Create App Packages**. Follow the prompts and run WACK tests. Make sure they all succeed.
4446
1. Follow the instructions at [Pull Requests](PullRequests.md) when making a pull request.
45-

Documentation/Contributing/CodingGuidelines.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ When you fix a bug, write a test to ensure it does not regress in the future. If
5151
All Microsoft employees contributing new files should add the following standard License header at the top of any new files, exactly as shown below:
5252

5353
```c#
54-
// Copyright (c) Microsoft Corporation. All rights reserved.
55-
// Licensed under the MIT License. See LICENSE in the project root for license information.
54+
// Copyright (c) Microsoft Corporation.
55+
// Licensed under the MIT License.
5656
```
5757

5858
### Function / Method summary headers

Documentation/Contributing/UnitTests.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,8 +207,8 @@ Edit mode tests are executed in Unity's edit mode and can be added under the **M
207207
To create a new test the following template can be used:
208208

209209
``` csharp
210-
// Copyright (c) Microsoft Corporation. All rights reserved.
211-
// Licensed under the MIT License. See LICENSE in the project root for license information.
210+
// Copyright (c) Microsoft Corporation.
211+
// Licensed under the MIT License.
212212
213213
using NUnit.Framework;
214214

0 commit comments

Comments
 (0)