PR nits

Zee2 · Zee2 · commit bdbcfcf04a96 · 2021-06-22T09:50:58.000-07:00
diff --git a/Assets/MRTK/SDK/Features/UX/Scripts/BoundsControl/Visuals/ScaleHandles.cs b/Assets/MRTK/SDK/Features/UX/Scripts/BoundsControl/Visuals/ScaleHandles.cs
@@ -200,7 +200,7 @@ protected Quaternion GetRotationRealignment(int handleIndex, bool isFlattened)
                 switch(currentFlattenAxis)
                 {
                     case FlattenModeType.FlattenAuto:
-                        Debug.LogError("ScaleHandles should never receive FlattenAuto. BoundsControl should pass actualFlattenAxis");
+                        Debug.LogError("ScaleHandles should never receive FlattenAuto. BoundsControl should pass ActualFlattenAxis");
                         break;
                     case FlattenModeType.FlattenX:
                         axis = Vector3.right;
diff --git a/Assets/MRTK/SDK/Features/UX/Scripts/BoundsControl/Visuals/VisualUtils.cs b/Assets/MRTK/SDK/Features/UX/Scripts/BoundsControl/Visuals/VisualUtils.cs
@@ -262,6 +262,9 @@ static internal Vector3 GetFaceCenterPosition(int faceIndex, ref Vector3[] corne
         /// <returns>Flattened indices.</returns>
         internal static List<int> GetFlattenedIndices(FlattenModeType flattenAxis, CardinalAxisType[] axisArray)
         {
+            Debug.Assert(flattenAxis != FlattenModeType.FlattenAuto,
+                         "FlattenAuto passed to GetFlattenedIndices. Resolve FlattenAuto into an actual axis before calling.");
+                         
             List<int> flattenedIndices = new List<int>();
             for (int i = 0; i < axisArray.Length; ++i)
             {

Original file line number	Diff line number	Diff line change
`@@ -200,7 +200,7 @@ protected Quaternion GetRotationRealignment(int handleIndex, bool isFlattened)`
`200`	`200`	`switch(currentFlattenAxis)`
`201`	`201`	`{`
`202`	`202`	`case FlattenModeType.FlattenAuto:`
`203`		`- Debug.LogError("ScaleHandles should never receive FlattenAuto. BoundsControl should pass actualFlattenAxis");`
	`203`	`+ Debug.LogError("ScaleHandles should never receive FlattenAuto. BoundsControl should pass ActualFlattenAxis");`
`204`	`204`	`break;`
`205`	`205`	`case FlattenModeType.FlattenX:`
`206`	`206`	`axis = Vector3.right;`
Original file line number	Diff line number	Diff line change
`@@ -262,6 +262,9 @@ static internal Vector3 GetFaceCenterPosition(int faceIndex, ref Vector3[] corne`
`262`	`262`	`/// <returns>Flattened indices.</returns>`
`263`	`263`	`internal static List<int> GetFlattenedIndices(FlattenModeType flattenAxis, CardinalAxisType[] axisArray)`
`264`	`264`	`{`
	`265`	`+ Debug.Assert(flattenAxis != FlattenModeType.FlattenAuto,`
	`266`	`+ "FlattenAuto passed to GetFlattenedIndices. Resolve FlattenAuto into an actual axis before calling.");`
	`267`	`+`
`265`	`268`	`List<int> flattenedIndices = new List<int>();`
`266`	`269`	`for (int i = 0; i < axisArray.Length; ++i)`
`267`	`270`	`{`