Skip to content

Commit d9d2931

Browse files
author
Stephen Hodgson
committed
Fixed scaling for each image type.
1 parent 7ddb583 commit d9d2931

File tree

1 file changed

+35
-26
lines changed

1 file changed

+35
-26
lines changed

Assets/HoloToolkit/Utilities/Scripts/Editor/SetIconsWindow.cs

Lines changed: 35 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -341,63 +341,61 @@ private static Vector2 GetUWPImageTypeSize(PlayerSettings.WSAImageType type, Pla
341341
switch (scale)
342342
{
343343
case PlayerSettings.WSAImageScale.Target16:
344-
return CreateSize(16);
344+
return CreateSquareSize(16);
345345
case PlayerSettings.WSAImageScale.Target24:
346-
return CreateSize(24);
346+
return CreateSquareSize(24);
347347
case PlayerSettings.WSAImageScale.Target32:
348-
return CreateSize(32);
348+
return CreateSquareSize(32);
349349
case PlayerSettings.WSAImageScale.Target48:
350-
return CreateSize(48);
350+
return CreateSquareSize(48);
351351
case PlayerSettings.WSAImageScale.Target256:
352-
return CreateSize(256);
352+
return CreateSquareSize(256);
353353
default:
354354
return GetWSAImageTypeSize(type, scale);
355355
}
356356
}
357357

358358
private static Vector2 GetWSAImageTypeSize(PlayerSettings.WSAImageType type, PlayerSettings.WSAImageScale scale)
359359
{
360+
float scaleFactor = float.Parse(scale.ToString().Replace("_", "")) * 0.01f;
361+
360362
switch (type)
361363
{
362364
case PlayerSettings.WSAImageType.PackageLogo:
363-
return CreateSize(50);
365+
return CreateSquareSize(50, scaleFactor);
364366
case PlayerSettings.WSAImageType.StoreTileLogo:
365-
return CreateSize(150);
367+
return CreateSquareSize(150, scaleFactor);
366368
case PlayerSettings.WSAImageType.StoreTileSmallLogo:
367-
return CreateSize(30);
369+
return CreateSquareSize(30, scaleFactor);
368370
case PlayerSettings.WSAImageType.StoreSmallTile:
369-
return CreateSize(70);
371+
return CreateSquareSize(70, scaleFactor);
370372
case PlayerSettings.WSAImageType.StoreLargeTile:
371-
return CreateSize(310);
373+
return CreateSquareSize(310, scaleFactor);
372374
case PlayerSettings.WSAImageType.PhoneAppIcon:
373-
return CreateSize(44);
375+
return CreateSquareSize(44, scaleFactor);
374376
case PlayerSettings.WSAImageType.PhoneSmallTile:
375-
return CreateSize(71);
377+
return CreateSquareSize(71, scaleFactor);
376378
case PlayerSettings.WSAImageType.PhoneMediumTile:
377-
return CreateSize(150);
379+
return CreateSquareSize(150, scaleFactor);
378380
case PlayerSettings.WSAImageType.UWPSquare44x44Logo:
379-
return CreateSize(44);
381+
return CreateSquareSize(44, scaleFactor);
380382
case PlayerSettings.WSAImageType.UWPSquare71x71Logo:
381-
return CreateSize(71);
383+
return CreateSquareSize(71, scaleFactor);
382384
case PlayerSettings.WSAImageType.UWPSquare150x150Logo:
383-
return CreateSize(150);
385+
return CreateSquareSize(150, scaleFactor);
384386
case PlayerSettings.WSAImageType.UWPSquare310x310Logo:
385-
return CreateSize(310);
387+
return CreateSquareSize(310, scaleFactor);
386388

387389
// WIDE 31:15
388390
case PlayerSettings.WSAImageType.PhoneWideTile:
389391
case PlayerSettings.WSAImageType.StoreTileWideLogo:
390392
case PlayerSettings.WSAImageType.UWPWide310x150Logo:
391-
return new Vector2(310, 150);
393+
return CreateSize(new Vector2(310, 150), scaleFactor);
392394
case PlayerSettings.WSAImageType.SplashScreenImage:
393-
return new Vector2(620, 300);
395+
return CreateSize(new Vector2(620, 300), scaleFactor);
394396
case PlayerSettings.WSAImageType.PhoneSplashScreen:
395397
default:
396-
var size = Vector2.zero;
397-
float scaleFactor = float.Parse(scale.ToString().Replace("_", "")) * 0.01f;
398-
size = size * scaleFactor;
399-
size.x = (float)Math.Ceiling(size.x);
400-
size.y = (float)Math.Ceiling(size.y);
398+
var size = CreateSquareSize(0, scaleFactor);
401399

402400
if (size == Vector2.zero)
403401
{
@@ -408,9 +406,20 @@ private static Vector2 GetWSAImageTypeSize(PlayerSettings.WSAImageType type, Pla
408406
}
409407
}
410408

411-
private static Vector2 CreateSize(int size)
409+
private static Vector2 CreateSquareSize(int size, float scaleFactor = 0f)
410+
{
411+
var newSize = new Vector2(size * scaleFactor, size * scaleFactor);
412+
newSize.x = (float)Math.Ceiling(newSize.x);
413+
newSize.y = (float)Math.Ceiling(newSize.y);
414+
return newSize;
415+
}
416+
417+
private static Vector2 CreateSize(Vector2 size, float scaleFactor = 0f)
412418
{
413-
return new Vector2(size, size);
419+
var newSize = new Vector2(size.x * scaleFactor, size.y * scaleFactor);
420+
newSize.x = (float)Math.Ceiling(newSize.x);
421+
newSize.y = (float)Math.Ceiling(newSize.y);
422+
return newSize;
414423
}
415424
}
416425
}

0 commit comments

Comments
 (0)