Skip to content

Commit f505ce6

Browse files
author
David Kline (ANALOG)
committed
more pr feedback
1 parent 1107436 commit f505ce6

File tree

4 files changed

+9
-3
lines changed

4 files changed

+9
-3
lines changed

Assets/MixedRealityToolkit-SDK/Features/SpatialAwareness/System/MixedRealitySpatialAwarenessSystem.cs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,8 @@ public float UpdateInterval
389389
{
390390
if (IsObserverRunning)
391391
{
392-
throw new System.InvalidOperationException("UpdateInterval cannot be modified while the observer is running.");
392+
Debug.LogError("UpdateInterval cannot be modified while the observer is running.");
393+
return;
393394
}
394395

395396
updateInterval = value;
@@ -448,7 +449,8 @@ public SpatialAwarenessMeshLevelOfDetail MeshLevelOfDetail
448449
{
449450
if (IsObserverRunning)
450451
{
451-
throw new System.InvalidOperationException("MeshLevelOfDetail cannot be modified while the observer is running.");
452+
Debug.LogError("MeshLevelOfDetail cannot be modified while the observer is running.");
453+
return;
452454
}
453455

454456
if (meshLevelOfDetail != value)
@@ -478,7 +480,8 @@ public int MeshTrianglesPerCubicMeter
478480
{
479481
if (IsObserverRunning)
480482
{
481-
throw new System.InvalidOperationException("MeshTrianglesPerCubicMeter cannot be modified while the observer is running.");
483+
Debug.LogError("MeshTrianglesPerCubicMeter cannot be modified while the observer is running.");
484+
return;
482485
}
483486

484487
meshTrianglesPerCubicMeter = value;

Assets/MixedRealityToolkit/_Core/EventDatum/SpatialAwareness/MixedRealitySpatialAwarenessBaseEventData.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ public class MixedRealitySpatialAwarenessBaseEventData : GenericBaseEventData
4343
/// <param name="eventSystem"></param>
4444
protected MixedRealitySpatialAwarenessBaseEventData(EventSystem eventSystem) : base(eventSystem) { }
4545

46+
/// <inheritdoc />
4647
protected void Initialize(
4748
IMixedRealitySpatialAwarenessSystem spatialAwarenessSystem,
4849
uint id,

Assets/MixedRealityToolkit/_Core/EventDatum/SpatialAwareness/MixedRealitySpatialAwarenessMeshEventData.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ public class MixedRealitySpatialAwarenessMeshEventData : MixedRealitySpatialAwar
2424
/// <param name="eventSystem"></param>
2525
public MixedRealitySpatialAwarenessMeshEventData(EventSystem eventSystem) : base(eventSystem) { }
2626

27+
/// <inheritdoc />
2728
public void Intialize(
2829
IMixedRealitySpatialAwarenessSystem spatialAwarenessSystem,
2930
SpatialAwarenessEventType eventType,

Assets/MixedRealityToolkit/_Core/EventDatum/SpatialAwareness/MixedRealitySpatialAwarenessSurfaceFindingEventData.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ public class MixedRealitySpatialAwarenessSurfaceFindingEventData : MixedRealityS
2424
/// <param name="eventSystem"></param>
2525
public MixedRealitySpatialAwarenessSurfaceFindingEventData(EventSystem eventSystem) : base(eventSystem) { }
2626

27+
/// <inheritdoc />
2728
public void Intialize(
2829
IMixedRealitySpatialAwarenessSystem spatialAwarenessSystem,
2930
SpatialAwarenessEventType eventType,

0 commit comments

Comments
 (0)