Skip to content

fix: to pass con str instead of key #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

fix: to pass con str instead of key #170

merged 1 commit into from
May 2, 2025

Conversation

@marktayl1
Copy link
Contributor

Purpose

  • ...Currently local debug fails as configure_azure_monitor required a connection_string for that param

Does this introduce a breaking change?

  • Yes
  • [x ] No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@Fr4nc3 Fr4nc3 merged commit adfc30e into main May 2, 2025
6 of 8 checks passed
@github-actions
Copy link

github-actions bot commented May 2, 2025

🎉 This PR is included in version 1.3.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@marktayl1 marktayl1 deleted the marktayl/fix-key-to-conn-str-telemetry branch July 21, 2025 16:23
blessing-msft pushed a commit that referenced this pull request Aug 1, 2025
@Fr4nc3
Merge pull request #170 from microsoft/marktayl/fix-key-to-conn-str-t…
f2ca95b 
…elemetry

fix: to pass con str instead of key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fr4nc3 Fr4nc3 Fr4nc3 approved these changes

@Roopan-Microsoft Roopan-Microsoft Awaiting requested review from Roopan-Microsoft Roopan-Microsoft is a code owner

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marktayl1 @Fr4nc3