Skip to content

Conversation

@Prashant-Microsoft
Copy link
Contributor

@Prashant-Microsoft Prashant-Microsoft commented May 14, 2025

Purpose

This pull request introduces several changes to the infrastructure configuration, primarily focusing on improving naming conventions, updating dependencies, and simplifying resource references. The key updates include replacing the prefix parameter with a dynamically generated solutionPrefix, updating the Bicep version, and refining resource references for better maintainability.

Naming Convention Updates:

  • Replaced the prefix parameter with a dynamically generated solutionPrefix to ensure unique and consistent naming across resources. This affects multiple variables and resource names, such as aiServicesName, containerApp, and aiproject. ([[1]](https://github.com/microsoft/Multi-Agent-Custom-Automation-Engine-Solution-Accelerator/pull/209/files#diff-0504f5a35afecd5c8c2a1dc8cac5bb558cc1456c557d8edcb7f9bac1c0dc36e4L51-R56), [[2]](https://github.com/microsoft/Multi-Agent-Custom-Automation-Engine-Solution-Accelerator/pull/209/files#diff-0504f5a35afecd5c8c2a1dc8cac5bb558cc1456c557d8edcb7f9bac1c0dc36e4R109-R120), [[3]](https://github.com/microsoft/Multi-Agent-Custom-Automation-Engine-Solution-Accelerator/pull/209/files#diff-0504f5a35afecd5c8c2a1dc8cac5bb558cc1456c557d8edcb7f9bac1c0dc36e4L265-R265), [[4]](https://github.com/microsoft/Multi-Agent-Custom-Automation-Engine-Solution-Accelerator/pull/209/files#diff-0504f5a35afecd5c8c2a1dc8cac5bb558cc1456c557d8edcb7f9bac1c0dc36e4L344-R344), [[5]](https://github.com/microsoft/Multi-Agent-Custom-Automation-Engine-Solution-Accelerator/pull/209/files#diff-0504f5a35afecd5c8c2a1dc8cac5bb558cc1456c557d8edcb7f9bac1c0dc36e4L535-R535), [[6]](https://github.com/microsoft/Multi-Agent-Custom-Automation-Engine-Solution-Accelerator/pull/209/files#diff-0504f5a35afecd5c8c2a1dc8cac5bb558cc1456c557d8edcb7f9bac1c0dc36e4L546-R547), [[7]](https://github.com/microsoft/Multi-Agent-Custom-Automation-Engine-Solution-Accelerator/pull/209/files#diff-0504f5a35afecd5c8c2a1dc8cac5bb558cc1456c557d8edcb7f9bac1c0dc36e4L568-R568), [[8]](https://github.com/microsoft/Multi-Agent-Custom-Automation-Engine-Solution-Accelerator/pull/209/files#diff-0504f5a35afecd5c8c2a1dc8cac5bb558cc1456c557d8edcb7f9bac1c0dc36e4L688-R688), [[9]](https://github.com/microsoft/Multi-Agent-Custom-Automation-Engine-Solution-Accelerator/pull/209/files#diff-0504f5a35afecd5c8c2a1dc8cac5bb558cc1456c557d8edcb7f9bac1c0dc36e4L1097-R1097))

Dependency Updates:

  • Updated the Bicep version from 0.34.44.8038 to 0.35.1.17967 in the metadata section of infra/main.json. ([[1]](https://github.com/microsoft/Multi-Agent-Custom-Automation-Engine-Solution-Accelerator/pull/209/files#diff-0504f5a35afecd5c8c2a1dc8cac5bb558cc1456c557d8edcb7f9bac1c0dc36e4L8-R9), [[2]](https://github.com/microsoft/Multi-Agent-Custom-Automation-Engine-Solution-Accelerator/pull/209/files#diff-0504f5a35afecd5c8c2a1dc8cac5bb558cc1456c557d8edcb7f9bac1c0dc36e4L583-R584), [[3]](https://github.com/microsoft/Multi-Agent-Custom-Automation-Engine-Solution-Accelerator/pull/209/files#diff-0504f5a35afecd5c8c2a1dc8cac5bb558cc1456c557d8edcb7f9bac1c0dc36e4L721-R722), [[4]](https://github.com/microsoft/Multi-Agent-Custom-Automation-Engine-Solution-Accelerator/pull/209/files#diff-0504f5a35afecd5c8c2a1dc8cac5bb558cc1456c557d8edcb7f9bac1c0dc36e4L1115-R1116))

Resource Reference Simplifications:

  • Simplified resource references by replacing explicit resourceId calls with direct resource names where applicable, such as in listKeys and logAnalytics. ([[1]](https://github.com/microsoft/Multi-Agent-Custom-Automation-Engine-Solution-Accelerator/pull/209/files#diff-0504f5a35afecd5c8c2a1dc8cac5bb558cc1456c557d8edcb7f9bac1c0dc36e4L318-R318), [[2]](https://github.com/microsoft/Multi-Agent-Custom-Automation-Engine-Solution-Accelerator/pull/209/files#diff-0504f5a35afecd5c8c2a1dc8cac5bb558cc1456c557d8edcb7f9bac1c0dc36e4L709-R709))

Application Version Standardization:

  • Updated the appVersion variable from a specific version (fnd01) to latest for consistency and flexibility in deployments. ([[1]](https://github.com/microsoft/Multi-Agent-Custom-Automation-Engine-Solution-Accelerator/pull/209/files#diff-7ef659fc9cf6968e718894d300490b14ea7a52091e7d4bcffae3a5029ac721d4L68-R68), [[2]](https://github.com/microsoft/Multi-Agent-Custom-Automation-Engine-Solution-Accelerator/pull/209/files#diff-0504f5a35afecd5c8c2a1dc8cac5bb558cc1456c557d8edcb7f9bac1c0dc36e4R109-R120))

Minor Adjustments:

  • Removed redundant properties, such as disableLocalAuth, from the aiServices resource configuration. ([infra/main.jsonL227-R228](https://github.com/microsoft/Multi-Agent-Custom-Automation-Engine-Solution-Accelerator/pull/209/files#diff-0504f5a35afecd5c8c2a1dc8cac5bb558cc1456c557d8edcb7f9bac1c0dc36e4L227-R228))

Does this introduce a breaking change?

  • Yes
  • No

@Roopan-Microsoft Roopan-Microsoft merged commit 3bb2512 into main May 14, 2025
7 of 9 checks passed
@Roopan-Microsoft Roopan-Microsoft deleted the psl-tag-change branch May 14, 2025 16:29
@github-actions
Copy link

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

blessing-msft pushed a commit that referenced this pull request Aug 1, 2025
feat: updated tag fnd01 to latest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants