Skip to content

Conversation

@Roopan-Microsoft
Copy link
Collaborator

Purpose

  • This pull request introduces several changes across multiple files, focusing on configuration updates, workflow optimizations, and resource naming standardization. The key updates include refining .flake8 exclusions, simplifying GitHub Actions workflows, implementing a comprehensive abbreviations system for Azure resource naming, and making adjustments to Azure Bicep templates for improved modularity and security.

Configuration Updates:

  • Updated .flake8 configuration to exclude src/backend/tests from linting.

Workflow Optimizations:

  • Simplified the template_validation_job in .github/workflows/azure-dev.yml by removing unnecessary steps, switching to environment variables (vars) for Azure credentials, and using the latest version of the template-validation-action.
  • Enhanced the docker-build-and-push.yml workflow by introducing historical tagging for Docker images and modularizing the build steps for backend and frontend images using docker/build-push-action. [1] [2]

Resource Naming Standardization:

  • Introduced a comprehensive abbreviations.json file to standardize Azure resource naming conventions across categories like AI, compute, databases, and networking.

Azure Bicep Template Improvements:

  • Updated infra/deploy_ai_foundry.bicep to use the new abbreviations for resource names, switched authType from ApiKey to AAD for AI Hub authentication, and added role assignments for AI Developers. [1] [2] [3]
  • Adjusted infra/deploy_keyvault.bicep to accept keyvaultName as a parameter, removed soft delete and purge protection options, and enabled RBAC authorization. [1] [2]

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

TravisHilbert and others added 30 commits May 5, 2025 11:25
feat: Add historical tagging and use build-push-action for Docker image build and push
docs: Change Version of packages in requirment.txt
@Avijit-Microsoft Avijit-Microsoft merged commit 250e6fd into main May 21, 2025
10 checks passed
@github-actions
Copy link

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

blessing-msft pushed a commit that referenced this pull request Aug 1, 2025
fix: merging dev to main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants