refactor: WAF aligned option for infra #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new Bicep parameter file `main.waf-aligned.bicepparam`. - Defined parameters for telemetry, solution prefix, solution location, and virtual machine configuration. - Set default values for admin username and password in the virtual machine configuration.
Update bicep files to deploy GSA with sandbox and/or waf aligned configuration options
…unique string - Update .bicepparam default files to allow null solutionPrefix for customizable resource naming.
…zureOpenAILocation param
…remove AZURE_LOCATION parameters
refactor: updated the naming conventions for all resources and added AzureOpenAILocation param
fix: Add Disclaimer message in task approval response
alguadam
requested review from
Avijit-Microsoft,
Fr4nc3,
Prajwal-Microsoft,
Roopan-Microsoft and
marktayl1
as code owners
alguadam
changed the title
aniaroramsft
approved these changes
May 29, 2025
|
🎉 This PR is included in version 1.5.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
blessing-msft
pushed a commit
that referenced
this pull request
Aug 1, 2025
refactor: WAF aligned option for infra
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The changes in this Pull Request introduces a new Bicep parameter file
main.bicepwhich is aligned with AVM standards and that includes deployment logic to provide both Sandbox and WAF-aligned configuration options for the infrastructure.README.md has been updated to reflect these changes and how users can swap between both configurations
Does this introduce a breaking change?
How to Test
Follow deployment instructions in README.md for both sandbox configuration and for WAF aligned configuration.
What to Check
Everything must deploy without errors (unless you hit any of the Azure limitations e.g. quota, region availability, etc.)
Other Information
We are currently working to address a bug which prevents container app to communicate with AI Foundry via private endpoints. For that reason, WAF aligned configuration leaves open Internet access to AI Foundry