feat: added rate limit error pop up #243
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prashant-Microsoft
requested review from
Avijit-Microsoft,
Fr4nc3,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft and
marktayl1
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces several updates across documentation, infrastructure configuration, backend error handling, and frontend user feedback. The most notable changes include adjustments to deployment descriptions, parameterization of AI Foundry resource capacity, improved backend error logging, and enhanced frontend handling of rate limit errors.
Documentation Updates:
documentation/DeploymentGuide.md: Clarified deployment times, specifying that the WAF-aligned deployment takes 25-45 minutes, compared to the default deployment's 4-6 minutes.Infrastructure Configuration:
infra/main.bicep: Added a new parameteraiFoundryCapacitywith a default value of 140, allowing customization of AI Foundry resource capacity for optimized performance. [1] [2]infra/main.bicepparam: Updated the default value ofaiFoundryCapacityto 140 and disabled the virtual network configuration for this deployment.Backend Error Handling:
src/backend/app_kernel.py: Enhanced error messages by including exception details in the HTTP response for better debugging.src/backend/kernel_agents/planner_agent.py: Added specific handling for rate limit errors, logging a warning and suggesting retrying after a delay.Frontend User Feedback:
src/frontend/wwwroot/home/home.js: Improved user experience by displaying an error notification when rate limits are exceeded, re-enabling disabled UI elements, and removing loading indicators.Does this introduce a breaking change?