fix: Update deployment parameters to fix the deployment pipeline issue #281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the deployment workflows to include additional configuration parameters for resource provisioning. The changes primarily enhance the flexibility and specificity of the deployment process by introducing new parameters for virtual machines, log analytics, application insights, virtual networks, and web server farms.
Workflow Updates:
.github/workflows/deploy-waf.yml:infra/main.waf-aligned.bicepparamwith inline parameters.virtualMachineConfiguration(admin credentials) andlogAnalyticsWorkspaceConfiguration(empty workspace resource ID)..github/workflows/deploy.yml:infra/main.bicepparamwith inline parameters.logAnalyticsWorkspaceConfiguration(data retention and workspace ID),applicationInsightsConfiguration(retention days),virtualNetworkConfiguration(enabled flag), andwebServerFarmConfiguration(SKU capacity and name).Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information