Skip to content

Conversation

@Abdul-Microsoft
Copy link
Contributor

Purpose

This pull request updates the deployment workflows to include additional configuration parameters for resource provisioning. The changes primarily enhance the flexibility and specificity of the deployment process by introducing new parameters for virtual machines, log analytics, application insights, virtual networks, and web server farms.

Workflow Updates:

  • .github/workflows/deploy-waf.yml:

    • Replaced infra/main.waf-aligned.bicepparam with inline parameters.
    • Added parameters for virtualMachineConfiguration (admin credentials) and logAnalyticsWorkspaceConfiguration (empty workspace resource ID).
  • .github/workflows/deploy.yml:

    • Replaced infra/main.bicepparam with inline parameters.
    • Added parameters for logAnalyticsWorkspaceConfiguration (data retention and workspace ID), applicationInsightsConfiguration (retention days), virtualNetworkConfiguration (enabled flag), and webServerFarmConfiguration (SKU capacity and name).

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit 279ca9a into main Jun 24, 2025
7 checks passed
blessing-msft pushed a commit that referenced this pull request Aug 1, 2025
fix: Update deployment parameters to fix the deployment pipeline issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants