Skip to content

Conversation

@Abdul-Microsoft
Copy link
Contributor

Purpose

This pull request introduces significant updates to the infrastructure and configuration files to support a more flexible deployment architecture, including a WAF-aligned option. Key changes include renaming parameters for clarity, adding support for existing Log Analytics workspaces, and introducing conditional configurations based on deployment architecture. Below is a summary of the most important changes grouped by theme:

Infrastructure Enhancements

  • Added a new parameter useWafAlignedArchitecture to enable WAF-aligned infrastructure deployments, affecting multiple configurations such as virtual networks, VM passwords, and SKU settings in infra/main.bicep. [1] [2] [3]
  • Introduced conditional logic for resource configurations, such as setting data retention and VM password based on the WAF-aligned architecture flag. [1] [2]

Parameter and Variable Updates

  • Renamed azureOpenAILocation to aiDeploymentsLocation across multiple files for consistency and clarity. [1] [2] [3]
  • Added new parameters such as existingLogAnalyticsWorkspaceId and gptModelCapacity for enhanced configuration flexibility. [1] [2]

Documentation Improvements

  • Updated docs/CustomizingAzdParameters.md to document the new AZURE_ENV_LOG_ANALYTICS_WORKSPACE_ID parameter and provide an example of how to set it. [1] [2]

Removal of Deprecated Hooks

  • Removed preprovision hooks from azure.yaml, simplifying the deployment process by eliminating script-based validation of model quotas.

Configuration File Simplification

  • Refactored infra/main.parameters.json and removed redundant parameter files like infra/main.bicepparam and infra/main.waf-aligned.bicepparam, consolidating parameter definitions for better maintainability. [1] [2] [3]

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft changed the title Feat: Merge the Azd Quota check changes from dev to main feat: Merge the Azd Quota check changes from dev to main Jun 26, 2025
@Roopan-Microsoft Roopan-Microsoft merged commit 2ba411a into main Jun 26, 2025
10 of 11 checks passed
blessing-msft pushed a commit that referenced this pull request Aug 1, 2025
feat: Merge the Azd Quota check changes from dev to main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants