Skip to content

Conversation

@NirajC-Microsoft
Copy link
Contributor

@NirajC-Microsoft NirajC-Microsoft commented Jul 4, 2025

This pull request introduces significant updates to the infra/main.bicep file and its dependent modules, focusing on enhancing AI Foundry project support, improving resource configurations, and cleaning up unused or redundant code. Key changes include adding support for existing AI Foundry projects, introducing new modules for role assignments and Key Vault exports, and removing deprecated or unnecessary configurations.

Enhancements to AI Foundry Project Support:

  • Support for existing AI Foundry projects: Added the existingFoundryProjectResourceId parameter to allow the use of pre-existing AI Foundry projects. Updated logic to dynamically handle existing or new projects in the infra/main.bicep file. [1] [2] [3] [4]
  • New project.bicep module: Introduced a dedicated module to manage AI Foundry project creation or reuse, including metadata outputs for project name, resource ID, and API endpoint.

Resource Configuration Improvements:

  • Role assignment modularization: Added a new role.bicep module to streamline the creation of role assignments for AI Foundry projects and Cognitive Services accounts. This includes support for multiple roles such as AI Developer and Cognitive Services OpenAI User.
  • Key Vault export module: Added keyVaultExport.bicep to enable exporting secrets to Azure Key Vaults, improving security and reusability.
  • Updated AI Foundry resource configurations: Enhanced the aiFoundryAiServices module to support network ACLs, telemetry, and private endpoint configurations.

Code Cleanup and Simplification:

  • Removed deprecated configurations: Cleaned up unused parameters, redundant resource definitions, and outdated comments across multiple sections of infra/main.bicep. Examples include removing telemetry resources and simplifying virtual network configurations. [1] [2] [3]
  • Simplified output definitions: Streamlined outputs for resources such as websites and container apps by removing unnecessary fields.

These changes collectively enhance the flexibility, maintainability, and security of the infrastructure deployment.## Purpose

  • ...

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@NirajC-Microsoft
Copy link
Contributor Author

@microsoft-github-policy-service agree

@Roopan-Microsoft Roopan-Microsoft merged commit 268e63d into dev Jul 4, 2025
7 checks passed
@Roopan-Microsoft Roopan-Microsoft deleted the psl-reuse-aif branch July 4, 2025 12:44
@github-actions
Copy link

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

blessing-msft pushed a commit that referenced this pull request Aug 1, 2025
chore: Reuse Ai Foundry for MACAE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants