Skip to content

fix: Fix to avoid task creation for violent and meaning less prompts when deployment reuse existing AI Foundry Project. #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: fix: Merging dev chnages for v2 version
merged 4 commits into from
Jul 9, 2025
Merged

fix: Fix to avoid task creation for violent and meaning less prompts when deployment reuse existing AI Foundry Project. #304

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6fe8692
Added condition for Azure openAI and Azure Ai Project name selection …
NirajC-Microsoft Jul 8, 2025
72f412e
remove type from existingAiFounryName
NirajC-Microsoft Jul 8, 2025
b566ffa
Private Connection should get used only for deployment which is creat…
NirajC-Microsoft Jul 8, 2025
2c63e5b
refactor: Code clean up for roleassignments
Prajwal-Microsoft Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions infra/main.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,7 +697,9 @@ module privateDnsZonesAiServices 'br/public:avm/res/network/private-dns-zone:0.7
]

// NOTE: Required version 'Microsoft.CognitiveServices/accounts@2024-04-01-preview' not available in AVM
var aiFoundryAiServicesResourceName = aiFoundryAiServicesConfiguration.?name ?? 'aisa-${solutionPrefix}'
var useExistingFoundryProject = !empty(existingFoundryProjectResourceId)
var existingAiFounryName = useExistingFoundryProject?split( existingFoundryProjectResourceId,'/')[8]:''
var aiFoundryAiServicesResourceName = useExistingFoundryProject? existingAiFounryName : aiFoundryAiServicesConfiguration.?name ?? 'aisa-${solutionPrefix}'
var aiFoundryAIservicesEnabled = aiFoundryAiServicesConfiguration.?enabled ?? true
var aiFoundryAiServicesModelDeployment = {
format: 'OpenAI'
Expand Down Expand Up @@ -743,8 +745,8 @@ module aiFoundryAiServices 'modules/account/main.bicep' = if (aiFoundryAIservice
privateEndpoints: virtualNetworkEnabled
? ([
{
name: 'pep-${aiFoundryAiServicesResourceName}'
customNetworkInterfaceName: 'nic-${aiFoundryAiServicesResourceName}'
name: 'pep-${aiFoundryAiServicesConfiguration.?name ?? 'aisa-${solutionPrefix}'}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not required as the check is already added in line 701

customNetworkInterfaceName: 'nic-${aiFoundryAiServicesConfiguration.?name ?? 'aisa-${solutionPrefix}'}'
subnetResourceId: aiFoundryAiServicesConfiguration.?subnetResourceId ?? virtualNetwork.outputs.subnetResourceIds[0]
privateDnsZoneGroup: {
privateDnsZoneGroupConfigs: map(objectKeys(openAiPrivateDnsZones), zone => {
Expand Down Expand Up @@ -775,7 +777,8 @@ module aiFoundryAiServices 'modules/account/main.bicep' = if (aiFoundryAIservice

// AI Foundry: AI Project
// WAF best practices for Open AI: https://learn.microsoft.com/en-us/azure/well-architected/service-guides/azure-openai
var aiFoundryAiProjectName = aiFoundryAiProjectConfiguration.?name ?? 'aifp-${solutionPrefix}'
var existingAiFounryProjectName = useExistingFoundryProject?last(split( existingFoundryProjectResourceId,'/')): ''
var aiFoundryAiProjectName = useExistingFoundryProject? existingAiFounryProjectName : aiFoundryAiProjectConfiguration.?name ?? 'aifp-${solutionPrefix}'

resource aiUser 'Microsoft.Authorization/roleDefinitions@2022-04-01' existing = {
name: '53ca6127-db72-4b80-b1b0-d745d6d5456d'
Expand Down
Loading