Skip to content

Conversation

@Abdul-Microsoft
Copy link
Contributor

Purpose

  • This pull request updates the infrastructure configuration in infra/main.bicep and infra/main.parameters.json to improve parameter clarity and align resource naming conventions with the environment name. The most important changes include replacing the solutionPrefix parameter with environmentName, introducing a new solutionPrefix definition, and adding empty zones to the bastion host configuration.

Parameter updates:

  • Replaced the solutionPrefix parameter with a new environmentName parameter to specify the deployment environment name, making it a required field. (infra/main.bicep, infra/main.bicepL10-R11)
  • Added a new solutionPrefix definition based on the environmentName, subscription ID, and resource group location to ensure consistent resource naming. (infra/main.bicep, infra/main.bicepR50-R51)

Bastion host configuration:

  • Updated the bastion host public IP configuration to include an empty zones array, likely as a placeholder for future zone-specific configurations. (infra/main.bicep, infra/main.bicepR620)

Parameter file adjustments:

  • Updated the infra/main.parameters.json file to replace the solutionPrefix parameter with the new environmentName parameter for consistency with the main Bicep file. (infra/main.parameters.json, infra/main.parameters.jsonL21-R21)

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@Abdul-Microsoft Abdul-Microsoft changed the base branch from main to dev July 15, 2025 11:59
@Roopan-Microsoft Roopan-Microsoft merged commit 8494ea9 into dev Jul 16, 2025
10 checks passed
@github-actions
Copy link

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

blessing-msft pushed a commit that referenced this pull request Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants