Skip to content

Conversation

@Abdul-Microsoft
Copy link
Contributor

Purpose

  • This pull request introduces changes to the Azure deployment workflow and the associated infrastructure code to improve naming consistency, enhance resource configuration, and simplify parameter usage. The key updates include replacing solutionPrefix with environmentName, generating a unique solution prefix dynamically, and modifying resource configurations for better cost efficiency and flexibility.

Workflow Updates

  • Dynamic Solution Prefix Generation: Added a step in .github/workflows/deploy-waf.yml to generate a unique SOLUTION_PREFIX dynamically using a timestamp, ensuring unique environment names for deployments.
  • Parameter Name Change: Updated workflow files to replace solutionPrefix with environmentName for better clarity and alignment with the new parameter naming convention. [1] [2]

Infrastructure Code Changes

  • Parameter Renaming: Replaced the solutionPrefix parameter with environmentName in infra/main.bicep, reflecting the updated naming convention.
  • New Solution Prefix Logic: Introduced a new solutionPrefix parameter in infra/main.bicep that dynamically generates a unique prefix using subscription and environment details.
  • Storage Configuration Update: Changed the storage account type for virtual machine disks from Premium_ZRS to Standard_LRS to optimize costs.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit 51c84be into main Jul 17, 2025
10 checks passed
@github-actions
Copy link

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants