Skip to content

fix: Prefix/Suffix fixes - dev to main #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2025
Merged

fix: Prefix/Suffix fixes - dev to main #344

merged 2 commits into from
Jul 24, 2025

Conversation

@NirajC-Microsoft
Copy link
Contributor

@NirajC-Microsoft NirajC-Microsoft commented Jul 23, 2025 •
edited
Loading

This pull request includes a small but important change to the infra/main.bicep file. It modifies the solutionPrefix parameter to include the resource group's name as part of the unique string generation, ensuring better differentiation of resources across deployments.

  • infra/main.bicep: Updated the solutionPrefix parameter to include resourceGroup().name in the unique string generation for improved resource identification.## Purpose
  • ...

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

NirajC-Microsoft and others added 2 commits July 23, 2025 15:02
@NirajC-Microsoft
Updated solutionPrefix param in main.bicep
49434b6
@Roopan-Microsoft
Merge pull request #343 from microsoft/psl-solPrefix-fix
ec23bc8 
fix: Updated solutionPrefix param in main.bicep to ensure resources name should be unique in each deployment.
@Roopan-Microsoft Roopan-Microsoft merged commit cd1cf07 into main Jul 24, 2025
11 checks passed
@github-actions
Copy link

🎉 This PR is included in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Roopan-Microsoft Roopan-Microsoft Roopan-Microsoft approved these changes

@Avijit-Microsoft Avijit-Microsoft Avijit-Microsoft approved these changes

@Prajwal-Microsoft Prajwal-Microsoft Awaiting requested review from Prajwal-Microsoft Prajwal-Microsoft is a code owner

@marktayl1 marktayl1 Awaiting requested review from marktayl1 marktayl1 is a code owner

@Fr4nc3 Fr4nc3 Awaiting requested review from Fr4nc3 Fr4nc3 is a code owner

@Vinay-Microsoft Vinay-Microsoft Awaiting requested review from Vinay-Microsoft Vinay-Microsoft is a code owner

@aniaroramsft aniaroramsft Awaiting requested review from aniaroramsft aniaroramsft is a code owner

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NirajC-Microsoft @Roopan-Microsoft @Avijit-Microsoft