feat: Json upload setting page #371

blessing-sanusi · 2025-08-07T19:09:17Z

Purpose

...

Does this introduce a breaking change?

Yes
No

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check

Verify that the following are valid

...

Other Information

Copilot

Pull Request Overview

This PR implements JSON team configuration upload functionality, allowing users to upload custom team configurations and select teams for plan creation. The feature includes team management UI components, RAI validation for uploaded content, and backend support for team configuration processing.

Adds team upload and selection interface with validation
Integrates team selection into the plan creation workflow
Implements RAI validation for team configuration content

Reviewed Changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
src/frontend/src/services/TeamService.ts	New service for team operations (upload, fetch, delete)
src/frontend/src/services/TaskService.tsx	Added team_id parameter to plan creation
src/frontend/src/pages/HomePage.tsx	Integrated team selection and upload functionality
src/frontend/src/components/common/SettingsButton.tsx	New team management UI component
src/frontend/src/models/Team.ts	Team data models and interfaces
src/backend/utils_kernel.py	RAI validation function for team configurations
src/backend/app_kernel.py	Added RAI validation to upload endpoint

Comments suppressed due to low confidence (1)

src/frontend/src/components/common/SettingsButton.tsx:136

The agent type name has a typo: "MaintanceKBAgent" should be "MaintenanceKBAgent" (missing 'e' in 'Maintenance')

    setIsOpen(false);

Copilot · 2025-08-11T08:28:01Z

src/frontend/src/models/enums.tsx

+    FILE_SURFER = "FileSurfer",
+    WEB_SURFER = "WebSurfer",
+    SENSOR_SENTINEL = "SensorSentinel",
+    MAINTENANCE_KB_AGENT = "MaintanceKBAgent",


The agent type name has a typo: "MaintanceKBAgent" should be "MaintenanceKBAgent" (missing 'e' in 'Maintenance')

Suggested change

MAINTENANCE_KB_AGENT = "MaintanceKBAgent",

MAINTENANCE_KB_AGENT = "MaintenanceKBAgent",

Copilot · 2025-08-11T08:28:02Z

src/frontend/src/models/enums.tsx

+    PLANNER = "Planner_Agent",
+
+    // Common uploadable agent types
+    MAGENTIC_ONE = "MagenticOne",


The agent type name appears to have a typo: "MagenticOne" should likely be "MagneticOne" (missing 'i' in 'Magnetic')

Suggested change

MAGENTIC_ONE = "MagenticOne",

MAGNETIC_ONE = "MagneticOne",

Copilot · 2025-08-11T08:28:02Z

src/frontend/src/models/enums.tsx

+            return 'system';
+        }
+
+        // MagenticOne framework agents


The comment has a typo: "MagenticOne" should likely be "MagneticOne" (missing 'i' in 'Magnetic')

Suggested change

// MagenticOne framework agents

// MagneticOne framework agents

Copilot · 2025-08-11T08:28:02Z

src/frontend/src/models/enums.tsx

+        // MagenticOne framework agents
+        if (typeStr === 'MagenticOne' || [
+            'Coder', 'Executor', 'FileSurfer', 'WebSurfer'
+        ].includes(typeStr)) {
+            return 'magentic-one';


The agent type comparison has a typo: "MagenticOne" should likely be "MagneticOne" (missing 'i' in 'Magnetic')

Suggested change

// MagenticOne framework agents

if (typeStr === 'MagenticOne' || [

'Coder', 'Executor', 'FileSurfer', 'WebSurfer'

].includes(typeStr)) {

return 'magentic-one';

// MagneticOne framework agents

if (typeStr === 'MagneticOne' || [

'Coder', 'Executor', 'FileSurfer', 'WebSurfer'

].includes(typeStr)) {

return 'magnetic-one';

Copilot · 2025-08-11T08:28:03Z

src/frontend/src/models/enums.tsx

+        if (typeStr === 'MagenticOne' || [
+            'Coder', 'Executor', 'FileSurfer', 'WebSurfer'
+        ].includes(typeStr)) {
+            return 'magentic-one';


The category name has a typo: "magentic-one" should likely be "magnetic-one" (missing 'i' in 'magnetic')

Suggested change

if (typeStr === 'MagenticOne' || [

'Coder', 'Executor', 'FileSurfer', 'WebSurfer'

].includes(typeStr)) {

return 'magentic-one';

if (typeStr === 'MagneticOne' || [

'Coder', 'Executor', 'FileSurfer', 'WebSurfer'

].includes(typeStr)) {

return 'magnetic-one';

Copilot · 2025-08-11T08:28:03Z

src/frontend/src/models/enums.tsx

+        switch (category) {
+            case 'system':
+                return 'Person';
+            case 'magentic-one':


The category case has a typo: "magentic-one" should likely be "magnetic-one" (missing 'i' in 'magnetic')

Suggested change

case 'magentic-one':

case 'magnetic-one':

Copilot · 2025-08-11T08:28:03Z

src/frontend/src/components/common/SettingsButton.tsx

+      // First, validate the file type
+      if (!file.name.toLowerCase().endsWith('.json')) {
+        throw new Error('Please upload a valid JSON file');


File type validation relies only on file extension which can be easily bypassed. Consider also validating the actual file content or MIME type for better security.

Suggested change

// First, validate the file type

if (!file.name.toLowerCase().endsWith('.json')) {

throw new Error('Please upload a valid JSON file');

// First, validate the file type by extension and MIME type

const validMimeTypes = ['application/json', 'text/json'];

if (

!file.name.toLowerCase().endsWith('.json') ||

(file.type && !validMimeTypes.includes(file.type))

) {

throw new Error('Please upload a valid JSON file (with .json extension and correct file type)');

Copilot · 2025-08-11T08:28:04Z

src/frontend/src/services/TeamService.ts

+            // Check if this is an RAI validation error
+            const errorDetail = error.response?.data?.detail || error.response?.data;
+
+            // If the error message contains "inappropriate content", treat it as RAI error
+            if (typeof errorDetail === 'string' && errorDetail.includes('inappropriate content')) {
+                return {
+                    success: false,
+                    raiError: {
+                        error_type: 'RAI_VALIDATION_FAILED',


Using string matching to detect RAI errors is fragile and could break if error messages change. Consider using structured error codes or types instead.

Suggested change

// Check if this is an RAI validation error

const errorDetail = error.response?.data?.detail || error.response?.data;

// If the error message contains "inappropriate content", treat it as RAI error

if (typeof errorDetail === 'string' && errorDetail.includes('inappropriate content')) {

return {

success: false,

raiError: {

error_type: 'RAI_VALIDATION_FAILED',

// Check if this is an RAI validation error using structured error code

const errorType = error.response?.data?.error_type;

const errorDetail = error.response?.data?.detail || error.response?.data?.message || error.response?.data;

if (errorType === 'RAI_VALIDATION_FAILED') {

return {

success: false,

raiError: {

error_type: errorType,

…e AI Foundry - Add POST /api/upload_team_config endpoint for team configuration management - Implement FoundryAgentService for bulk agent creation with error handling - Add comprehensive RAI validation for all uploaded content - Add team selection UI with search, delete, and validation features - Add model deployment and search index validation services

Fr4nc3 · 2025-08-12T18:33:12Z

src/frontend/src/services/TeamService.ts

@@ -0,0 +1,103 @@
+import { TeamConfig } from '../models/Team';


convert this file to tsx

Fr4nc3 · 2025-08-12T18:34:15Z

src/frontend/src/models/messages.tsx

    action: string;
    /** Agent assigned to this step */
-    agent: AgentType;
+    agent: AgentTypeString;


can you put back the AgentType instead of AgentTypeString

Fr4nc3 · 2025-08-12T18:34:27Z

src/frontend/src/models/homeInput.tsx

 }

-export const quickTasks: QuickTask[] = [
-    {


Fr4nc3 · 2025-08-12T18:36:00Z

src/frontend/src/models/enums.tsx

+    RAG = "RAG",
+
+    // Specific agent names (can be any name with any type)
+    CODER = "Coder",


this are not agent type,
Agent Type can be Custom, RAG, MagenticOne the other are Agent names

Fr4nc3 · 2025-08-12T18:54:54Z

src/backend/app_kernel.py

        raise HTTPException(status_code=500, detail="Internal server error occurred")


+@app.post("/api/upload_scenarios")


what are sceenarios?? I don't think we upload scenarios by themselves but as part of the teams only

take endpoint out

Fr4nc3 · 2025-08-12T18:56:44Z

src/backend/services/model_validation_service.py

+    """Service for validating model deployments in Azure AI Foundry"""
+
+    def __init__(self):
+        self.subscription_id = os.getenv("AZURE_AI_SUBSCRIPTION_ID")


this should come from the configuration file

Fr4nc3 · 2025-08-12T18:57:06Z

src/backend/services/search_validation_service.py

+
+    def __init__(self):
+        """Initialize the search validation service."""
+        self.search_endpoint = os.getenv("AZURE_SEARCH_ENDPOINT")


this should come from the validation file

Fr4nc3 · 2025-08-12T19:06:49Z

src/frontend/src/models/Team.ts

+export interface Agent {
+    input_key: string;
+    type: string;
+    name: string;


they should be tsx extension

Fr4nc3 · 2025-08-12T19:08:34Z

src/frontend/src/models/enums.tsx

+    PLANNER = "Planner_Agent",
+
+    // Common uploadable agent types
+    MAGENTIC_ONE = "MagenticOne",


Magentic one is not a name of Agent is a Agent Type, however, I think we will review this complete logic because in V3 the agent type are the agent names, and agent type will MagenticOne, Custom, and RAG

Moved data files to new locations, added new backend app.py, and introduced v3 MCP server modules with supporting services, configuration, and orchestration. Updated documentation for Docker MCP server testing and Azure AI Foundry project reuse. Improved deployment guides and infrastructure outputs for better environment configuration.

github-actions · 2025-09-23T09:33:49Z

🎉 This PR is included in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

blessing-sanusi added 4 commits August 5, 2025 17:42

setting page

48ef9f7

Merge branch 'macae-v3-dev' into json-upload-settingPage

e3a40b9

setting page

b9509b0

team's upload and team's id passed

2c79c57

blessing-sanusi requested review from Avijit-Microsoft, Fr4nc3, Prajwal-Microsoft, Roopan-Microsoft, Vinay-Microsoft, aniaroramsft and marktayl1 as code owners August 7, 2025 19:09

blessing-sanusi added 4 commits August 7, 2025 15:21

RAI validation

7b15649

team_id passed input_task object

81f64e0

json upload files

5c608e3

json upload files

8f0edcb

Ravikirana-Microsoft requested a review from Copilot August 11, 2025 08:25

Copilot AI reviewed Aug 11, 2025

View reviewed changes

blessing-sanusi added 2 commits August 11, 2025 18:10

json upload files authentications, deletion and model validation

fbc261e

Fr4nc3 reviewed Aug 12, 2025

View reviewed changes

blessing-sanusi and others added 3 commits August 12, 2025 17:47

json upload files authentications, deletion and model validation

b129362

change agentTypeString to AgentType

0699ef8

Fr4nc3 merged commit e20d063 into macae-v3-dev Aug 13, 2025
2 of 4 checks passed

Fr4nc3 deleted the json-upload-settingPage branch August 14, 2025 15:32

github-actions bot added the released label Sep 23, 2025

	MAINTENANCE_KB_AGENT = "MaintanceKBAgent",
	MAINTENANCE_KB_AGENT = "MaintenanceKBAgent",

	// MagenticOne framework agents
	// MagneticOne framework agents

-      // First, validate the file type
-      if (!file.name.toLowerCase().endsWith('.json')) {
-        throw new Error('Please upload a valid JSON file');
+      // First, validate the file type by extension and MIME type
+      const validMimeTypes = ['application/json', 'text/json'];
+      if (
+        !file.name.toLowerCase().endsWith('.json') ||
+        (file.type && !validMimeTypes.includes(file.type))
+      ) {
+        throw new Error('Please upload a valid JSON file (with .json extension and correct file type)');

		@@ -0,0 +1,103 @@
		import { TeamConfig } from '../models/Team';

		raise HTTPException(status_code=500, detail="Internal server error occurred")


		@app.post("/api/upload_scenarios")

feat: Json upload setting page #371

feat: Json upload setting page #371

Uh oh!

Conversation

blessing-sanusi commented Aug 7, 2025

Purpose

Does this introduce a breaking change?

How to Test

What to Check

Other Information

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Sep 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants