Skip to content

Conversation

UtkarshMishra-Microsoft
Copy link
Contributor

@UtkarshMishra-Microsoft UtkarshMishra-Microsoft commented Jan 15, 2025

Purpose

Title: Implement Unit Testing for Remaining Backend Code
This pull request includes several updates to the codebase, primarily focusing on standardizing import paths, modifying GitHub workflows, and updating configuration files. Below are the most important changes:

Standardizing Import Paths:

  • Updated import paths in various agent files to use src.backend for consistency. (src/backend/agents/agentutils.py, src/backend/agents/base_agent.py, src/backend/agents/generic.py, src/backend/agents/group_chat_manager.py, src/backend/agents/hr.py, src/backend/agents/human.py, src/backend/agents/marketing.py, src/backend/agents/planner.py, src/backend/agents/procurement.py, src/backend/agents/product.py, src/backend/agents/tech_support.py, src/backend/app.py, src/backend/context/cosmos_memory.py) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]

Modifying GitHub Workflows:

  • Updated the docker-build-and-push.yml workflow to use ${{ github.head.ref }} instead of ${{ github.ref }} for setting Docker image tags. (.github/workflows/docker-build-and-push.yml)
  • Removed redundant pip install pytest-cov and pip install pytest-asyncio commands from the test workflow. (.github/workflows/test.yml) [1] [2]

Configuration File Updates:

  • Added E402 to the list of ignored errors in the .flake8 configuration file. (.flake8)

These changes aim to improve the consistency and maintainability of the codebase, streamline the CI/CD workflows, and update the linting configuration.

Description: We have shortlisted the framework for unit testing for the backend code, and we have successfully created unit tests for some of the backend files. These unit tests have already been integrated with the CI pipeline. Our current work involves creating unit test coverage for the remaining backend files of Business in a Box.


Scope:
Completed -
Screen Shot of coverage 84%
image

image

image

  • ...

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit f8640d9 into hotfix Feb 3, 2025
5 checks passed
@github-actions
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Fr4nc3 pushed a commit to Fr4nc3/Multi-Agent-Custom-Automation-Engine-Solution-Accelerator that referenced this pull request Oct 6, 2025
* edit 1

* edit 2

* Repository Governance

* added stale-bot

* stalebot test

* chNGED TO 1 DAY

* edit 3

* Create test

* edit1

* edit2

* edit 4

* edit 5

* edit 6

* edit 6

* edit 7

* edit 8

* edit 5

* edit 10

* edit 11

* edit 12

* edit 13

* Update stale-bot.yml

* edit 14

* edit 15

* edit 16

* edit 17

* Update stale-bot.yml

* Update CODEOWNER

* Create nwetest

* added pylint

* changed flak loc

* edit 1

* add backend test workflow

* added test file

* edit 2

* added  sample test file

* changed py version

* made edits to workflow

* pass even if test filesa r not present

* removed test file

* added sample test file

* Create docker-build-and-push.yml

* Delete test

* Delete src/backend/middleware/test_health_check.py

* Delete .github/nwetest

* Delete .github/workflows/CI.yml

* updated docker

* Testcases

* Testcases

* Testcases

* Update test.yml

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Pylint issues fixed

* pylint issues fixed

* Pylint issues fixed

* Pylint issues fixed

* pylint fixed for line

* fix for test cases failure

* added agentutils test

* updated test utils file

* Testcases

* Testcases

* Testcases

* Testcases

* added genric test file

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* solving pylint errors

* resolved pylint errors

* edit 2

* resolving pylint

* edit 3

* resolved issue

* resolve edit 5

* resoleving pylint edit 6

* pylint error edit 7

* Update test.yml

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Update test.yml

* Update test.yml

* Update test.yml

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Testing

* Testing

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* added test_base_agent file

* Testcases

* Testcases

* Testcases

* Testcases

* added the test_agentutils and test_base_agent

* deleted agentutils.py

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* Testcases

* edited flak

* resolved pylint issues

* Test case Group_chat_manager

* Test case Group_chat_manager

* updated test_agentutils.py

* editv1

* resolving pylint issue

* edit 2

* Testcases

* Testcases

* Testcases

* Testcases

* docker changes reverted

---------

Co-authored-by: Harmanpreet Kaur <[email protected]>
Co-authored-by: Harmanpreet-Microsoft <[email protected]>
Co-authored-by: Roopan P M <[email protected]>
Co-authored-by: Pradheep-Microsoft <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants