Skip to content

fix: task with zero stages cannot show the page, spins forever and rai test prompt #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2025
Merged

fix: task with zero stages cannot show the page, spins forever and rai test prompt #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 50 additions & 34 deletions src/backend/agents/planner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,56 +60,57 @@ async def handle_input_task(self, message: InputTask, ctx: MessageContext) -> Pl
[UserMessage(content=instruction, source="PlannerAgent")]
)

await self._memory.add_item(
AgentMessage(
session_id=message.session_id,
user_id=self._user_id,
plan_id=plan.id,
content=f"Generated a plan with {len(steps)} steps. Click the blue check box beside each step to complete it, click the x to remove this step.",
source="PlannerAgent",
step_id="",
)
)
logging.info(f"Plan generated: {plan.summary}")

track_event(
f"Planner - Generated a plan with {len(steps)} steps and added plan into the cosmos",
{
"session_id": message.session_id,
"user_id": self._user_id,
"plan_id": plan.id,
"content": f"Generated a plan with {len(steps)} steps. Click the blue check box beside each step to complete it, click the x to remove this step.",
"source": "PlannerAgent",
},
)

if plan.human_clarification_request is not None:
# if the plan identified that user information was required, send a message asking the user for it
if steps:
await self._memory.add_item(
AgentMessage(
session_id=message.session_id,
user_id=self._user_id,
plan_id=plan.id,
content=f"I require additional information before we can proceed: {plan.human_clarification_request}",
content=f"Generated a plan with {len(steps)} steps. Click the blue check box beside each step to complete it, click the x to remove this step.",
source="PlannerAgent",
step_id="",
)
)
logging.info(
f"Additional information requested: {plan.human_clarification_request}"
)
logging.info(f"Plan generated: {plan.summary}")

track_event(
"Planner - Additional information requested and added into the cosmos",
f"Planner - Generated a plan with {len(steps)} steps and added plan into the cosmos",
{
"session_id": message.session_id,
"user_id": self._user_id,
"plan_id": plan.id,
"content": f"I require additional information before we can proceed: {plan.human_clarification_request}",
"content": f"Generated a plan with {len(steps)} steps. Click the blue check box beside each step to complete it, click the x to remove this step.",
"source": "PlannerAgent",
},
)

if plan.human_clarification_request is not None:
# if the plan identified that user information was required, send a message asking the user for it
await self._memory.add_item(
AgentMessage(
session_id=message.session_id,
user_id=self._user_id,
plan_id=plan.id,
content=f"I require additional information before we can proceed: {plan.human_clarification_request}",
source="PlannerAgent",
step_id="",
)
)
logging.info(
f"Additional information requested: {plan.human_clarification_request}"
)

track_event(
"Planner - Additional information requested and added into the cosmos",
{
"session_id": message.session_id,
"user_id": self._user_id,
"plan_id": plan.id,
"content": f"I require additional information before we can proceed: {plan.human_clarification_request}",
"source": "PlannerAgent",
},
)

return plan

@message_handler
Expand Down Expand Up @@ -251,6 +252,21 @@ class StructuredOutputPlan(BaseModel):
# Parse the LLM response
parsed_result = json.loads(content)
structured_plan = StructuredOutputPlan(**parsed_result)

if not structured_plan.steps:
track_event(
"Planner agent - No steps found",
{
"session_id":self._session_id,
"user_id":self._user_id,
"initial_goal":structured_plan.initial_goal,
"overall_status":"No steps found",
"source":"PlannerAgent",
"summary":structured_plan.summary_plan_and_steps,
"human_clarification_request":structured_plan.human_clarification_request
},
)
raise ValueError("No steps found")

# Create the Plan instance
plan = Plan(
Expand Down Expand Up @@ -318,17 +334,17 @@ class StructuredOutputPlan(BaseModel):
"initial_goal": "Error generating plan",
"overall_status": PlanStatus.failed,
"source": "PlannerAgent",
"summary": "Error generating plan",
"summary": f"Error generating plan: {e}",
},
)
# Handle the error, possibly by creating a plan with an error step
plan = Plan(
id=str(uuid.uuid4()),
id="", # No need of plan id as the steps are not getting created
session_id=self._session_id,
user_id=self._user_id,
initial_goal="Error generating plan",
overall_status=PlanStatus.failed,
source="PlannerAgent",
summary="Error generating plan",
summary=f"Error generating plan: {e}",
)
return plan, []
4 changes: 2 additions & 2 deletions src/backend/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,15 +157,15 @@ async def input_task_endpoint(input_task: InputTask, request: Request):
track_event(
"InputTaskProcessed",
{
"status": f"Plan created:\n {plan.summary}",
"status": f"Plan created:\n {plan.summary}" if plan.id else "Error occurred: Plan ID is empty",
"session_id": input_task.session_id,
"plan_id": plan.id,
"description": input_task.description,
},
)

return {
"status": f"Plan created:\n {plan.summary}",
"status": f"Plan created:\n {plan.summary}" if plan.id else "Error occurred: Plan ID is empty",
"session_id": input_task.session_id,
"plan_id": plan.id,
"description": input_task.description,
Expand Down
3 changes: 2 additions & 1 deletion src/frontend/wwwroot/home/home.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,11 @@
})
.then((response) => response.json())
.then((data) => {
if (data.status == "Plan not created") {
if (data.status == "Plan not created" || data.plan_id == "") {
notyf.error("Unable to create plan for this task.");
newTaskPrompt.disabled = false;
startTaskButton.disabled = false;
hideOverlay();
return;
}

Expand Down
Loading