feat: merged to main from dev #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tiple modules and update dependencies in pyproject.toml
…ompliance with Azure standards
…tter clarity and maintainability
- Simplified the output structure in `ai-project.bicep` by directly outputting project name, resource ID, and API endpoint instead of using a separate output type. - Deleted the `ai-services.bicep`, `dependencies.bicep`, and `keyVaultExport.bicep` modules as they are no longer needed. - Introduced a new module `ai-services-model-deployments.bicep` to handle cognitive services account deployments and role assignments. - Updated role assignment handling to utilize built-in role names for better clarity and maintainability.
… update references
…D for clarity and update related references
… clarify AI Project resource ID
…le existing project condition
…ndencies in aiServicesName assignment
…nment by removing conditional check
… subscription ID assignment for existing AI projects
…existingAiFoundryAiProjectResourceId
refactor: consolidate AI Foundry AVM + custom code
feat: Refactor private DNS zone creation and add support for reusing existing Foundry project and Log Analytics workspace
…rk access is enabled for Container App Environment and Web App.
refactor: Merging the AVM Waf Standard changes to dev branch
…rs, including VM credentials and Azure Developer CLI requirements.
fix: update README and align Data Collection Rule location with workspace
Dhruvkumar-Microsoft
requested review from
Avijit-Microsoft,
Fr4nc3,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft and
marktayl1
as code owners
Roopan-Microsoft
approved these changes
Sep 2, 2025
Avijit-Microsoft
approved these changes
Sep 2, 2025
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces significant improvements and modernization to the Azure deployment templates and documentation for the solution accelerator. The changes focus on simplifying and standardizing parameter names, enhancing support for production (WAF-aligned) deployments, improving documentation for deployment prerequisites and configuration, and modularizing the Bicep infrastructure code.
Key changes:
Infrastructure Parameter Standardization and Modernization
infra/main.parameters.json,infra/main.waf.parameters.json, and GitHub Actions workflows for consistency (e.g.,environmentName→solutionName,solutionLocation→location,aiDeploymentsLocation→azureAiServiceLocation,modelDeploymentType→gptModelDeploymentType). [1] [2] [3] [4]Enhanced Production/Well-Architected (WAF) Support
infra/main.waf.parameters.jsonfile for WAF-aligned, production-ready deployments, enabling telemetry, monitoring, private networking, scalability, and explicit VM admin credentials.deploy.ymlanddeploy-waf.yml) to use the new standardized parameter names and to enable relevant production features for WAF deployments. [1] [2]Documentation Improvements
azd) version 1.18.0 or higher, with upgrade instructions for all major operating systems.Bicep Module Enhancements
ai-project.bicepmodule for deploying AI Foundry projects, with outputs for name, resource ID, and API endpoint.ai-services-deployments.bicepmodule for deploying Cognitive Services model deployments and role assignments, including support for a wide range of built-in role names.These changes collectively improve the clarity, maintainability, and production-readiness of the deployment process, making it easier to configure, deploy, and operate the solution in both development and enterprise environments.
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information