feat: Macae v3 dev marktayl #428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleted the scenarios package and onboarding_cases.py, which contained employee onboarding test cases and examples. This cleanup removes unused or obsolete scenario definitions from the backend.
MCP server name and description now default to 'MCPGreetingServer' and a descriptive string if not set in environment. MCPConfig now reads endpoint, name, and description from app config for improved flexibility.
Deleted multiple CSV and JSON files containing sample datasets from the data/datasets directory. This cleanup may be in preparation for new data sources, restructuring, or to remove obsolete test data.
Introduces a plan_id field to the InputTask model and ensures it is set if missing in the process_request API endpoint. Also updates response to include plan_id, modifies .env.sample, switches dependency from fastmcp to mcp in pyproject.toml, and comments out user ownership check in team_service.
Introduces the UserCurrentTeam model to represent a user's current team. Updates the API router to generate a new plan with a unique ID and store it in the database, removing plan_id and team_id from InputTask. Plan creation now includes initial goal and status.
Changed Plan model to use plan_id and made team_id optional. Refactored plan creation logic in router.py to handle plan creation errors, removed mandatory team_id check, and added event tracking for plan creation success and failure.
Changed MCP_SERVER_ENDPOINT port in .env.sample from 9000 to 8080. Fixed API response in router.py to return the correct plan_id variable instead of input_task.plan_id.
Fr4nc3
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft and
marktayl1
as code owners
blessing-sanusi
approved these changes
Sep 2, 2025
marktayl1
approved these changes
Sep 2, 2025
Replaces getUserId with headerBuilder for authentication, improves connection logic by validating user ID, and removes redundant comments and unused code for clarity. Enhances error handling and streamlines reconnection and subscription management.
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information