Skip to content

fix: Separate out config for AZURE_OPENAI_MODEL_NAME and AZURE_OPENAI_DEPLOYMENT_NAME - Fixes #35 #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix: Separate out config for AZURE_OPENAI_MODEL_NAME and AZURE_OPENAI_DEPLOYMENT_NAME - Fixes #35 #44

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
508950d
Separate config for AOAI Model and Deployment Name
timothymeyers Jan 21, 2025
edfb128
Merge branch 'microsoft:main' into timothymeyers/issue35-config-updates
timothymeyers Jan 21, 2025
7d905be
Move model name to optional config and use deployment name if not pre…
timothymeyers Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/backend/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ class Config:
COSMOSDB_CONTAINER = GetRequiredConfig("COSMOSDB_CONTAINER")

AZURE_OPENAI_DEPLOYMENT_NAME = GetRequiredConfig("AZURE_OPENAI_DEPLOYMENT_NAME")
AZURE_OPENAI_MODEL_NAME = GetOptionalConfig("AZURE_OPENAI_MODEL_NAME", default=AZURE_OPENAI_DEPLOYMENT_NAME)
AZURE_OPENAI_API_VERSION = GetRequiredConfig("AZURE_OPENAI_API_VERSION")
AZURE_OPENAI_ENDPOINT = GetRequiredConfig("AZURE_OPENAI_ENDPOINT")
AZURE_OPENAI_API_KEY = GetOptionalConfig("AZURE_OPENAI_API_KEY")
Expand Down Expand Up @@ -87,7 +88,8 @@ def GetAzureOpenAIChatCompletionClient(model_capabilities):
if Config.AZURE_OPENAI_API_KEY == "":
# Use DefaultAzureCredential for auth
Config.__aoai_chatCompletionClient = AzureOpenAIChatCompletionClient(
model=Config.AZURE_OPENAI_DEPLOYMENT_NAME,
model=Config.AZURE_OPENAI_MODEL_NAME,
azure_deployment=Config.AZURE_OPENAI_DEPLOYMENT_NAME,
api_version=Config.AZURE_OPENAI_API_VERSION,
azure_endpoint=Config.AZURE_OPENAI_ENDPOINT,
azure_ad_token_provider=Config.GetTokenProvider(
Expand All @@ -99,7 +101,8 @@ def GetAzureOpenAIChatCompletionClient(model_capabilities):
else:
# Fallback behavior to use API key
Config.__aoai_chatCompletionClient = AzureOpenAIChatCompletionClient(
model=Config.AZURE_OPENAI_DEPLOYMENT_NAME,
model=Config.AZURE_OPENAI_MODEL_NAME,
azure_deployment=Config.AZURE_OPENAI_DEPLOYMENT_NAME,
api_version=Config.AZURE_OPENAI_API_VERSION,
azure_endpoint=Config.AZURE_OPENAI_ENDPOINT,
api_key=Config.AZURE_OPENAI_API_KEY,
Expand Down
Loading