Macae v3 fr dev 92 #455
Merged
Macae v3 fr dev 92 #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved WebSocket-related types (StreamMessage, StreamingPlanUpdate, etc.) from the service to the models directory for better separation of concerns. Introduced a WebsocketMessageType enum for consistent message type handling. Updated imports and usages across components, hooks, and services to use the new model definitions. Improved message handling logic in WebSocketService for clarity and maintainability.
Replaced hardcoded 'parsed_plan_approval_request' string with WebsocketMessageType.PLAN_APPROVAL_REQUEST enum across components, models, and services for improved type safety and maintainability.
Replaced string literals with WebsocketMessageType enum for agent messages and plan approval events in PlanPage and PlanDataService. This improves type safety and consistency when handling websocket events.
Replaces string literals with DataType enum for data_type fields and queries in models and CosmosDB client for consistency and type safety. Adds PlanService to encapsulate plan approval logic and updates router to use this service, improving separation of concerns and error handling.
Introduces the TeamSelected component for displaying the current team. Updates PlanPanelLeft, HomePage, and PlanPage to support an isHomePage prop and refines team selection and upload handling. Also updates PlanPanelLefProps interface to include isHomePage.
Replaces usage of current_team.id with current_team.team_id when fetching plans, ensuring correct team identifier is used for plan retrieval.
Refactored Plan model fields in frontend to match backend, replacing 'title' and 'description' with 'initial_goal' and updating status fields. Adjusted backend to ensure plan completion only when total steps are greater than zero. Updated API and TaskService to use new fields and status logic for consistency.
Replaced usage of 'description' with 'initial_goal' in PlanChat component and updated plan status check from 'status' to 'overall_status' in TaskService. These changes align with updated plan data structure.
Commented out in-progress step display in TaskList and simplified skeleton rendering logic. Modified TaskService to categorize completed tasks only by overall_status, removing PlanDataService.isPlanComplete check.
Simplifies and restructures PlanDataService.parsePlanApprovalRequest to handle multiple input formats more robustly and consistently. Removes redundant code, improves normalization, and enhances step extraction. Adds a debug log for PLAN_APPROVAL_REQUEST in WebSocketService and adjusts agent message handling to always transform message data.
Moved user plan, plan response, and thinking state rendering logic from PlanChat.tsx into dedicated streaming components for improved modularity and maintainability. Added StreamingPlanResponse, StreamingPlanState, StreamingUserPlan, and StreamingUserPlanMessage components. Updated PlanChat to use these new components and simplified its structure.
Moved the chat input UI from PlanChat.tsx into a new PlanChatBody.tsx component for better separation of concerns and maintainability. Also performed minor variable renaming in StreamingUserPlanMessage.tsx and removed an unused import in StreamingUserPlan.tsx.
Moves plan approval request and waiting state management from PlanChat and PlanPanelRight into PlanPage, passing them as props. This centralizes WebSocket handling and plan state, simplifies component logic, and ensures consistent plan approval UI updates across components.
Introduces a new StreamingBufferMessage component to render live agent message streams in PlanChat. Updates PlanPage and WebSocketService to handle and buffer streaming agent messages, improving real-time feedback during plan generation.
Introduces support for streaming agent messages in the plan chat by adding the AgentMessageData model, a new StreamingAgentMessage renderer, and updating PlanChat and PlanPage to handle and display agent messages. This enhances visibility into agent activity during plan generation.
Fr4nc3
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft and
marktayl1
as code owners
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information