fix: added the correct env variable and updated the search index to take json file #478
+22
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates environment variable assignments and output values in the Bicep infrastructure files to use
aiSearchConnectionNameinstead ofsearchService.outputs.namefor the Azure AI Search connection name. Additionally, there is a modification in the dataset indexing script that affects how blob file names are processed. These changes help ensure consistency in naming and potentially broaden support for different file types.Infrastructure configuration updates:
AZURE_AI_SEARCH_CONNECTION_NAMEenvironment variable in bothinfra/main.bicepandinfra/main_custom.bicepto useaiSearchConnectionNameinstead ofsearchService.outputs.name. [1] [2]AZURE_AI_SEARCH_CONNECTION_NAMEin bothinfra/main.bicepandinfra/main_custom.bicepto useaiSearchConnectionNamefor consistency. [1] [2]Dataset indexing script adjustment:
infra/scripts/index_datasets.pyto remove the.jsonextension instead of.csv, and commented out the previous.csvcheck, which may affect how datasets are indexed from blob storage.Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information