Skip to content

Conversation

@Dhruvkumar-Microsoft
Copy link
Contributor

Purpose

This pull request updates environment variable assignments and output values in the Bicep infrastructure files to use aiSearchConnectionName instead of searchService.outputs.name for the Azure AI Search connection name. Additionally, there is a modification in the dataset indexing script that affects how blob file names are processed. These changes help ensure consistency in naming and potentially broaden support for different file types.

Infrastructure configuration updates:

  • Updated the value assigned to the AZURE_AI_SEARCH_CONNECTION_NAME environment variable in both infra/main.bicep and infra/main_custom.bicep to use aiSearchConnectionName instead of searchService.outputs.name. [1] [2]
  • Changed the output value for AZURE_AI_SEARCH_CONNECTION_NAME in both infra/main.bicep and infra/main_custom.bicep to use aiSearchConnectionName for consistency. [1] [2]

Dataset indexing script adjustment:

  • Modified the file name processing in infra/scripts/index_datasets.py to remove the .json extension instead of .csv, and commented out the previous .csv check, which may affect how datasets are indexed from blob storage.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit 89c33d7 into macae-v3-dev-v2-vip Sep 10, 2025
2 of 3 checks passed
@github-actions
Copy link

🎉 This PR is included in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Dhruvkumar-Microsoft Dhruvkumar-Microsoft deleted the psl-bug-23298 branch September 24, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants