Skip to content

Conversation

@VishalS-Microsoft
Copy link
Contributor

Purpose

This pull request enhances resource deployment workflows by adding more detailed tagging for auditing and traceability, and improves template logic for resource classification. The main changes include adding a timestamp to deployment tags, including purpose and security control information in tags, and updating the infrastructure template to classify resource type based on networking configuration.

Workflow improvements:

  • Added generation of a current UTC timestamp (current_date) in both deploy-waf.yml and deploy.yml workflows for use in resource tagging. [1] [2]
  • Updated Azure deployment commands to include a tags parameter, adding SecurityControl, Purpose, and the new CreatedDate fields for better resource tracking and validation. [1] [2]

Infrastructure template enhancements:

  • Modified infra/main.bicep to set the Type tag to 'WAF' or 'Non-WAF' based on the enablePrivateNetworking flag, improving resource classification.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit 6a56b26 into dev-v3 Sep 23, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants