Skip to content

Conversation

@Dhruvkumar-Microsoft
Copy link
Contributor

Purpose

This pull request updates the way the Log Analytics workspace resource ID is referenced in the Key Vault module configuration for both the standard and custom infrastructure templates. The change improves consistency and reliability by using the direct variable logAnalyticsWorkspaceResourceId instead of accessing the output property from the workspace object.

Key Vault module configuration updates:

  • Updated the diagnosticSettings property in infra/main.bicep to use logAnalyticsWorkspaceResourceId instead of logAnalyticsWorkspace!.outputs.resourceId.
  • Made the same update to the diagnosticSettings property in infra/main_custom.bicep.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit dae3a10 into dev-v3 Sep 23, 2025
3 of 4 checks passed
@Dhruvkumar-Microsoft Dhruvkumar-Microsoft deleted the psl-searchserviceissue branch September 24, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants