fix: added new 'type' tag and exp changes related to key vault

[Dhruvkumar-Microsoft]

Purpose

This pull request introduces enhancements to resource tagging and monitoring configuration in deployment workflows and infrastructure templates. The main focus is on improving traceability by adding timestamps to resource tags, distinguishing resource types based on networking configuration, and simplifying diagnostic settings for Key Vault modules.

Resource Tagging Improvements:

• Deployment workflows (.github/workflows/deploy.yml, .github/workflows/deploy-waf.yml): Added a CreatedDate timestamp to resource tags, generated in UTC at deployment time, to improve traceability of deployed resources. [1] [2] [3] [4]
• Infrastructure templates (infra/main.bicep, infra/main_custom.bicep): Added a Type tag to resource groups to distinguish between 'WAF' and 'Non-WAF' deployments based on the value of enablePrivateNetworking. [1] [2]

Monitoring Configuration Simplification:

• Key Vault modules (infra/main.bicep, infra/main_custom.bicep): Updated the diagnostic settings logic to use logAnalyticsWorkspaceResourceId directly, removing the need to access the workspace's outputs property. [1] [2]

Does this introduce a breaking change?

• Yes
• No

How to Test

• Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

• Test the code

What to Check

Verify that the following are valid

• ...

Other Information