Skip to content

fix: added dns for existing project to access #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

fix: added dns for existing project to access #544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1493763
added dns for existing project to access
AjitPadhi-Microsoft Oct 6, 2025
c2014c2
added main.json file
AjitPadhi-Microsoft Oct 10, 2025
ec3e82b
Merge remote-tracking branch 'origin/dev' into PSL-US-24142
AjitPadhi-Microsoft Oct 15, 2025
8dd5b74
fixed privet endpoint issue
AjitPadhi-Microsoft Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 27 additions & 9 deletions infra/main.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,11 +651,11 @@ var dnsZoneIndex = {
}

// List of DNS zone indices that correspond to AI-related services.
var aiRelatedDnsZoneIndices = [
dnsZoneIndex.cognitiveServices
dnsZoneIndex.openAI
dnsZoneIndex.aiServices
]
// var aiRelatedDnsZoneIndices = [
// dnsZoneIndex.cognitiveServices
// dnsZoneIndex.openAI
// dnsZoneIndex.aiServices
// ]

// ===================================================
// DEPLOY PRIVATE DNS ZONES
Expand All @@ -664,10 +664,7 @@ var aiRelatedDnsZoneIndices = [
// ===================================================
@batchSize(5)
module avmPrivateDnsZones 'br/public:avm/res/network/private-dns-zone:0.7.1' = [
for (zone, i) in privateDnsZones: if (enablePrivateNetworking && (!useExistingAiFoundryAiProject || !contains(
aiRelatedDnsZoneIndices,
i
))) {
for (zone, i) in privateDnsZones: if (enablePrivateNetworking) {
name: 'avm.res.network.private-dns-zone.${contains(zone, 'azurecontainerapps.io') ? 'containerappenv' : split(zone, '.')[1]}'
params: {
name: zone
Expand Down Expand Up @@ -756,6 +753,27 @@ module existingAiFoundryAiServicesDeployments 'modules/ai-services-deployments.b
}
}

// ========== Private Endpoint for Existing AI Services ========== //
var shouldCreatePrivateEndpoint = useExistingAiFoundryAiProject && enablePrivateNetworking
var isProjectPrivate = existingAiFoundryAiServices!.properties.publicNetworkAccess == 'Enabled' ? false : true
module existingAiServicesPrivateEndpoint './modules/existing-aif-private-endpoint.bicep' = if (shouldCreatePrivateEndpoint){
name: take('module.proj-private-endpoint.${existingAiFoundryAiServices.name}', 64)
params: {
isPrivate: isProjectPrivate
aiServicesName: existingAiFoundryAiServices.name
subnetResourceId: virtualNetwork!.outputs.backendSubnetResourceId
aiServicesId: existingAiFoundryAiServices.id
location: location
cognitiveServicesDnsZoneId: avmPrivateDnsZones[dnsZoneIndex.cognitiveServices]!.outputs.resourceId
openAiDnsZoneId: avmPrivateDnsZones[dnsZoneIndex.openAI]!.outputs.resourceId
aiServicesDnsZoneId: avmPrivateDnsZones[dnsZoneIndex.aiServices]!.outputs.resourceId
tags: tags
}
dependsOn: [
avmPrivateDnsZones
]
}

module aiFoundryAiServices 'br:mcr.microsoft.com/bicep/avm/res/cognitive-services/account:0.13.2' = if (!useExistingAiFoundryAiProject) {
name: take('avm.res.cognitive-services.account.${aiFoundryAiServicesResourceName}', 64)
params: {
Expand Down
Loading
Loading