Skip to content

Conversation

Harsh-Microsoft
Copy link
Contributor

Purpose

This pull request introduces significant improvements to the post-deployment experience for the Multi-Agent Custom Automation Engine Solution Accelerator, especially for users deploying via Azure Verified Modules (AVM). The changes include a new, detailed post-deployment guide, enhanced automation scripts for configuration and data setup, improved resource and subscription detection, and tagging enhancements for better traceability.

Documentation enhancements:

  • Added a comprehensive AVMPostDeploymentGuide.md to help users complete post-deployment steps after AVM deployments, including prerequisites, step-by-step instructions, and troubleshooting tips.

Automation and configuration improvements:

  • Refactored Team-Config-And-Data.ps1 to automatically detect deployment method, retrieve configuration values from either azd environment or Azure deployment outputs, and guide users through Azure subscription selection and authentication, reducing manual input and errors.
  • Updated Process-Sample-Data.ps1, Upload-Team-Config.ps1, and process_sample_data.sh scripts to accept and propagate AzSubscriptionId, ensuring correct resource targeting and subscription context during automation. [1] [2] [3] [4] [5] [6]
  • Improved error handling and validation in automation scripts to provide clear feedback and prevent misconfiguration during team setup and sample data processing.

Infrastructure and resource tagging:

  • Enhanced resource group tagging in both main.bicep and main_custom.bicep by adding a DeploymentName tag, improving traceability of deployments and simplifying output retrieval for post-deployment automation. [1] [2]

Minor code fixes:

  • Fixed a bug in index_datasets.py to ensure both .csv and .json file extensions are handled correctly when generating dataset titles.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces comprehensive post-deployment automation improvements and documentation for users deploying the Multi-Agent Custom Automation Engine Solution Accelerator via Azure Verified Modules (AVM). The key improvements include enhanced deployment method detection, automated resource configuration retrieval, and improved user experience through better error handling and subscription management.

Key Changes:

  • Enhanced automation scripts: Updated PowerShell and Bash scripts to automatically detect deployment method and retrieve configuration values from either azd environment or Azure deployment outputs
  • Improved subscription management: Added automatic Azure subscription detection, selection, and validation workflows
  • New documentation: Added comprehensive post-deployment guide specifically for AVM template users with step-by-step instructions

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
infra/scripts/Team-Config-And-Data.ps1 Major refactoring to add deployment method detection, subscription management, and configuration retrieval from Azure deployment outputs
infra/scripts/team_config_and_data.sh Similar refactoring as PowerShell version with enhanced automation and error handling
infra/scripts/Upload-Team-Config.ps1 Added AzSubscriptionId parameter support for consistent subscription context
infra/scripts/upload_team_config.sh Added azSubscriptionId parameter support for consistent subscription context
infra/scripts/Process-Sample-Data.ps1 Added AzSubscriptionId parameter support for consistent subscription context
infra/scripts/process_sample_data.sh Added azSubscriptionId parameter support for consistent subscription context
infra/main.bicep Added DeploymentName tag to resource group for improved deployment traceability
infra/main_custom.bicep Added DeploymentName tag to resource group for improved deployment traceability
infra/scripts/index_datasets.py Fixed bug in file extension handling for dataset title generation
docs/AVMPostDeploymentGuide.md New comprehensive post-deployment guide for AVM template users

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Harsh-Microsoft Harsh-Microsoft merged commit 80e704d into dev-v3 Oct 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants