fix: Updated the network module for macae-v3 #568
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes significant changes to how network security groups (NSGs) and subnet references are managed in the infrastructure Bicep codebase. The main update is the removal of explicit NSG module definitions and the transition to a new, consolidated
virtualNetwork
module that encapsulates subnet and NSG configuration. This change also updates all downstream modules to reference the new subnet output properties, improving clarity and maintainability.Networking architecture simplification:
networkSecurityGroupBackend
,networkSecurityGroupBastion
,networkSecurityGroupAdministration
,networkSecurityGroupContainers
,networkSecurityGroupWebsite
) frominfra/main.bicep
, consolidating NSG and subnet management into the newvirtualNetwork
module.modules/virtualNetwork.bicep
module, which now handles subnet creation and NSG assignment internally.Subnet output property updates:
virtualNetwork
module (e.g.,backendSubnetResourceId
,administrationSubnetResourceId
,containerSubnetResourceId
,webserverfarmSubnetResourceId
) instead of array indices (e.g.,subnetResourceIds[0]
). This affects modules for VMs, AI services, Cosmos DB, Container Apps, Web Sites, Storage Accounts, and Key Vault. [1] [2] [3] [4] [5] [6] [7]These changes improve the maintainability and readability of the infrastructure code by centralizing network configuration and using descriptive output properties for subnet references.## Purpose
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information