Skip to content

Conversation

Dhruvkumar-Microsoft
Copy link
Contributor

Purpose

This pull request makes significant changes to how networking resources are defined and referenced in the infrastructure code, particularly by refactoring virtual network and subnet management to use a dedicated module and more explicit outputs. It also updates workflow triggers and environment variable handling in CI/CD pipelines. The most important changes are grouped below.

Infrastructure Networking Refactor

  • Replaced the direct definition of network security groups and virtual network in infra/main.bicep with a new modules/virtualNetwork.bicep module, removing inline NSG resource definitions and delegating subnet creation and management to the module. Subnet resource references throughout the file are now explicit (e.g., backendSubnetResourceId, administrationSubnetResourceId, etc.) instead of index-based access.
  • Updated all resource modules (VM, Cognitive Services, Cosmos DB, Container Apps, Web Sites, Storage Account, Key Vault) to reference subnets by new explicit output names from the virtual network module, improving clarity and maintainability. [1] [2] [3] [4] [5] [6] [7]

CI/CD Workflow Updates

  • Modified the Azure template validation workflow to remove the push trigger for the main branch, making the workflow only manually triggerable via workflow_dispatch.
  • Added support for passing the AZURE_DEV_COLLECT_TELEMETRY variable from GitHub Actions environment variables to the workflow, improving telemetry configuration flexibility.
  • Updated the deployment workflow to trigger on completion of the renamed workflow Build Docker and Optional Push v3 instead of the previous version.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Kanchan-Microsoft and others added 25 commits October 10, 2025 12:29
chore: Fixed security vulnerability
perf: added event polling instead of looping
chore: Add AZURE_DEV_COLLECT_TELEMETRY variable in azure-dev.yml file for MACAE-v3
fix: Add regular expression to avoid unnecessary citation in response
fix: Updated the network module for macae-v3
@Roopan-Microsoft Roopan-Microsoft merged commit 08eb37f into main Oct 20, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants