-
Notifications
You must be signed in to change notification settings - Fork 371
fix: dev-v3 to main branch merge #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: Fixed security vulnerability
fix: codeQL issue fix
perf: added event polling instead of looping
chore: Add AZURE_DEV_COLLECT_TELEMETRY variable in azure-dev.yml file for MACAE-v3
fix: Add regular expression to avoid unnecessary citation in response
fix: Updated the network module for macae-v3
Roopan-Microsoft
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request makes significant changes to how networking resources are defined and referenced in the infrastructure code, particularly by refactoring virtual network and subnet management to use a dedicated module and more explicit outputs. It also updates workflow triggers and environment variable handling in CI/CD pipelines. The most important changes are grouped below.
Infrastructure Networking Refactor
infra/main.bicep
with a newmodules/virtualNetwork.bicep
module, removing inline NSG resource definitions and delegating subnet creation and management to the module. Subnet resource references throughout the file are now explicit (e.g.,backendSubnetResourceId
,administrationSubnetResourceId
, etc.) instead of index-based access.CI/CD Workflow Updates
push
trigger for themain
branch, making the workflow only manually triggerable viaworkflow_dispatch
.AZURE_DEV_COLLECT_TELEMETRY
variable from GitHub Actions environment variables to the workflow, improving telemetry configuration flexibility.Build Docker and Optional Push v3
instead of the previous version.Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information