fix: Dev to macae-v2 merge #575
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request refactors the networking configuration in the infrastructure codebase to simplify and modularize the setup of Azure resources. The main change is the replacement of inline network security group and virtual network definitions with a dedicated module, which also updates how subnet resource IDs are referenced throughout the deployment. Additionally, minor workflow improvements have been made for Azure template validation.
Infrastructure refactoring and modularization:
infra/main.bicep
with a call to a dedicatedmodules/virtualNetwork.bicep
module. This change removes multiple network security group modules and consolidates subnet configuration, making the codebase easier to maintain and extend.infra/main.bicep
to use the new outputs from the modularized virtual network, such asbackendSubnetResourceId
,administrationSubnetResourceId
,containerSubnetResourceId
, andwebserverfarmSubnetResourceId
. This affects modules for virtual machines, AI services, Cosmos DB, container app environments, and web sites. [1] [2] [3] [4] [5]Workflow improvements:
push
trigger from the.github/workflows/azure-dev.yml
workflow, leaving only manual (workflow_dispatch
) execution. This prevents automatic runs on every push tomain
.AZURE_DEV_COLLECT_TELEMETRY
variable in the Azure template validation workflow, enabling telemetry collection configuration.Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information