Skip to content

Conversation

Dhruvkumar-Microsoft
Copy link
Contributor

Purpose

This pull request refactors the networking configuration in the infrastructure codebase to simplify and modularize the setup of Azure resources. The main change is the replacement of inline network security group and virtual network definitions with a dedicated module, which also updates how subnet resource IDs are referenced throughout the deployment. Additionally, minor workflow improvements have been made for Azure template validation.

Infrastructure refactoring and modularization:

  • Replaced the inline definitions of network security groups and the virtual network in infra/main.bicep with a call to a dedicated modules/virtualNetwork.bicep module. This change removes multiple network security group modules and consolidates subnet configuration, making the codebase easier to maintain and extend.
  • Updated references to subnet resource IDs throughout infra/main.bicep to use the new outputs from the modularized virtual network, such as backendSubnetResourceId, administrationSubnetResourceId, containerSubnetResourceId, and webserverfarmSubnetResourceId. This affects modules for virtual machines, AI services, Cosmos DB, container app environments, and web sites. [1] [2] [3] [4] [5]

Workflow improvements:

  • Removed the push trigger from the .github/workflows/azure-dev.yml workflow, leaving only manual (workflow_dispatch) execution. This prevents automatic runs on every push to main.
  • Added support for the AZURE_DEV_COLLECT_TELEMETRY variable in the Azure template validation workflow, enabling telemetry collection configuration.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit 2fc2c25 into macae-v2 Oct 20, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants