Macae rfp af 101725 #586
Merged
Macae rfp af 101725 #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved MagenticAgentFactory import to module level in orchestration_manager.py to avoid circular imports. Cleaned up unused agent instance cache and improved RAI verdict handling in utils_af.py by checking for 'TRUE' substring and simplifying response logic.
Replaces AIProjectClient with AzureAIAgentClient in agent lifecycle, updates FoundryAgentTemplate to use ChatAgent, and improves compatibility checks and error handling. Also updates RAI agent creation to use config-based deployment name and corrects logic for verdict handling.
Fr4nc3
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft and
marktayl1
as code owners
Added try/except blocks for chat client and manager instantiation in OrchestrationManager to log and raise errors. Also fixed import formatting and parameter names for AzureOpenAIChatClient. Minor formatting update in pyproject.toml dependencies.
The assignment of 'current_user_id' to kwargs has been commented out, possibly to prevent its propagation downstream. The user ID is still stored in the instance variable 'self.current_user_id'.
Fr4nc3
merged commit 836d2bb
into
microsoft:macae-rfp-agent-framework
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information