Skip to content

Conversation

@Priyanka-Microsoft
Copy link
Contributor

Add the variable AZURE_REGIONS with the value: eastus eastus2

Purpose:
This pull request includes changes to the deployment workflow and the checkquota.sh script to enhance flexibility and ensure required environment variables are set. The most important changes include adding a new environment variable for Azure regions and updating the script to dynamically read regions from this variable.

Improvements to deployment workflow and script:

  • .github/workflows/deploy.yml: Added AZURE_REGIONS environment variable to the deployment workflow to allow specifying Azure regions dynamically.
  • deploy/scripts/checkquota.sh: Modified the script to read Azure regions from the AZURE_REGIONS environment variable using IFS and read, replacing the hardcoded list of regions.
  • deploy/scripts/checkquota.sh: Updated the environment variable validation to include a check for the REGIONS variable to ensure it is set.

Does this introduce a breaking change?

No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit 478f053 into main Feb 26, 2025
8 checks passed
@github-actions
Copy link

🎉 This PR is included in version 1.2.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Priyanka-Microsoft Priyanka-Microsoft deleted the fix/dynamic-region-list-macae branch April 3, 2025 12:24
blessing-msft pushed a commit that referenced this pull request Aug 1, 2025
fix: quota check script with dynamic region handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants