Drivers: hv: mshv_vtl: TDX: Enable PARAVIRT CTLS for MCA and MTRR #105
+24
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep the same behavior regarding CPUID MCE, MCA, and MTRR by setting MCA and MTRR bits of PARAVIRT CTLS. TDX VE reduction changes guest behavior when the host and (L1) guest opt-in by setting TD_CTLS_REDUCE_VE. With REDUCE_VE enabled, the guest has to further opt in for each feature, like MCA and MTRR. Otherwise, such features are disabled. e.g., 0 in CPUID and #GP when accessing related MSRs. The upstream Linux TDX guest now opts in REDUCE VE and doesn't opt in any features, including MCA and MTRR. The L2 guest may be confused. Opt-in MCA and MTRR to keep the L0/L1 VMM behavior for the L2 guest to unblock it. As REDUCE VE defines other features, they are future TODO. Signed-off-by: Isaku Yamahata <[email protected]>
|
@microsoft-github-policy-service agree company="Intel corporation" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep the same behavior regarding CPUID MCE, MCA, and MTRR by setting MCA and MTRR bits of PARAVIRT CTLS.
TDX VE reduction changes guest behavior when the host and (L1) guest opt-in by setting TD_CTLS_REDUCE_VE. With REDUCE_VE enabled, the guest has to further opt in for each feature, like MCA and MTRR. Otherwise, such features are disabled. e.g., 0 in CPUID and #GP when accessing related MSRs.
The upstream Linux TDX guest now opts in REDUCE VE and doesn't opt in any features, including MCA and MTRR. The L2 guest may be confused. Opt-in MCA and MTRR to keep the L0/L1 VMM behavior for the L2 guest to unblock it. As REDUCE VE defines other features, they are future TODO.