Skip to content

[QAIRT] Implement QAIRT ORT->Genie workflow#2358

Draft
qti-kromero wants to merge 48 commits intomicrosoft:mainfrom
CodeLinaro:dev/qti-kromero/ort-genie-workflow
Draft

[QAIRT] Implement QAIRT ORT->Genie workflow#2358
qti-kromero wants to merge 48 commits intomicrosoft:mainfrom
CodeLinaro:dev/qti-kromero/ort-genie-workflow

Conversation

@qti-kromero
Copy link
Contributor

Describe your changes

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.

(Optional) Issue link

# --------------------------------------------------------------------------

import logging
import numbers

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'numbers' is not used.
import logging
import numbers
import os
from collections.abc import Mapping, MutableMapping

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'Mapping' is not used.
Import of 'MutableMapping' is not used.
import os
from collections.abc import Mapping, MutableMapping
from pathlib import Path
from typing import Any, ClassVar, Union

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'Any' is not used.
Import of 'ClassVar' is not used.

import json
import logging
import re

Check notice

Code scanning / CodeQL

Unused import Note

Import of 're' is not used.
import threading
from pathlib import Path
from queue import Empty, Queue
from typing import Union

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'Union' is not used.
from typing import Union

from olive.common.config_utils import ParamCategory
from olive.common.utils import hardlink_copy_file

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'hardlink_copy_file' is not used.
line = stdout_line.rstrip()
logger.info(line)
stdout_lines.append(line)
except Empty:

Check notice

Code scanning / CodeQL

Empty except Note

'except' clause does nothing but pass and there is no explanatory comment.
line = stderr_line.rstrip()
logger.debug(line)
stderr_lines.append(line)
except Empty:

Check notice

Code scanning / CodeQL

Empty except Note

'except' clause does nothing but pass and there is no explanatory comment.
Copy link
Contributor

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lintrunner found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant