Skip to content

Adds action/function suffix to tag names for action/function operations #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 20, 2025
Merged

Adds action/function suffix to tag names for action/function operations #641

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23a9fbe
Updated EdmOperationHandler to add a suffix incase operation segment …
Jan 17, 2025
547c7c0
Updated the case statement by explicitly checking if operation is an …
Jan 17, 2025
740d254
Reflection of #642
Jan 20, 2025
ef72b9e
Update expected test results
Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/Microsoft.OpenApi.OData.Reader/Operation/EdmOperationOperationHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ protected override void SetTags(OpenApiOperation operation)
}

/// <summary>
/// Genrates the tag name for the operation.
/// Genrates the tag name for the operation. Adds Action or Function name to the tag name if the operation is an action or function.
/// </summary>
/// <param name="tagName">The generated tag name.</param>
/// <param name="skip">The number of segments to skip.</param>
Expand All @@ -165,14 +165,17 @@ private void GenerateTagName(out string tagName, int skip = 1)
case ODataNavigationPropertySegment:
tagName = EdmModelHelper.GenerateNavigationPropertyPathTagName(Path, Context);
break;
case ODataOperationSegment:
case ODataOperationImportSegment:
// Previous segmment could be a navigation property or a navigation source segment
case ODataKeySegment:
skip += 1;
GenerateTagName(out tagName, skip);
break;
// ODataNavigationSourceSegment
// If the operation is a function or action, append the word "Function" or "Action" to the tag name
case ODataOperationSegment operationSegment:
string suffixName = operationSegment.Operation.IsAction() ? operationSegment.Operation.Name + "Actions" : operationSegment.Operation.Name + "Functions";
tagName = NavigationSource.Name + "." + NavigationSource.EntityType.Name + "." + suffixName;
break;
default:
tagName = NavigationSource.Name + "." + NavigationSource.EntityType.Name;
break;
Expand Down
Loading