Fix code smells

Author: MaggieKimani1

src/Microsoft.OpenApi.Readers/V3/OpenApiInfoDeserializer.cs

@@ -14,7 +14,7 @@ namespace Microsoft.OpenApi.Readers.V3
     /// </summary>
     internal static partial class OpenApiV3Deserializer
     {
-        public static FixedFieldMap<OpenApiInfo> InfoFixedFields = new FixedFieldMap<OpenApiInfo>
+        public static readonly FixedFieldMap<OpenApiInfo> InfoFixedFields = new FixedFieldMap<OpenApiInfo>
         {
             {
                 "title", (o, n) =>

src/Microsoft.OpenApi.Readers/V31/OpenApiInfoDeserializer.cs

@@ -11,7 +11,7 @@ namespace Microsoft.OpenApi.Readers.V31
     /// </summary>
     internal static partial class OpenApiV31Deserializer
     {
-        public static FixedFieldMap<OpenApiInfo> InfoFixedFields = new FixedFieldMap<OpenApiInfo>
+        public static readonly FixedFieldMap<OpenApiInfo> InfoFixedFields = new FixedFieldMap<OpenApiInfo>
         {
             {
                 "title", (o, n) =>
@@ -57,7 +57,7 @@ internal static partial class OpenApiV31Deserializer
             }
         };
 
-        public static PatternFieldMap<OpenApiInfo> InfoPatternFields = new PatternFieldMap<OpenApiInfo>
+        public static readonly PatternFieldMap<OpenApiInfo> InfoPatternFields = new PatternFieldMap<OpenApiInfo>
         {
             {s => s.StartsWith("x-"), (o, k, n) => o.AddExtension(k,LoadExtension(k, n))}
         };

src/Microsoft.OpenApi.Readers/V31/OpenApiResponsesDeserializer.cs

@@ -13,9 +13,9 @@ namespace Microsoft.OpenApi.Readers.V31
     /// </summary>
     internal static partial class OpenApiV31Deserializer
     {
-        public static FixedFieldMap<OpenApiResponses> ResponsesFixedFields = new FixedFieldMap<OpenApiResponses>();
+        public static readonly FixedFieldMap<OpenApiResponses> ResponsesFixedFields = new FixedFieldMap<OpenApiResponses>();
 
-        public static PatternFieldMap<OpenApiResponses> ResponsesPatternFields = new PatternFieldMap<OpenApiResponses>
+        public static readonly PatternFieldMap<OpenApiResponses> ResponsesPatternFields = new PatternFieldMap<OpenApiResponses>
         {
             {s => !s.StartsWith("x-"), (o, p, n) => o.Add(p, LoadResponse(n))},
             {s => s.StartsWith("x-"), (o, p, n) => o.AddExtension(p, LoadExtension(p,n))}

src/Microsoft.OpenApi/Extensions/OpenApiReferencableExtensions.cs

@@ -59,8 +59,6 @@ private static IOpenApiReferenceable ResolveReferenceOnHeaderElement(
         {
             switch (propertyName)
             {
-                case OpenApiConstants.Schema:
-                    return (IOpenApiReferenceable)headerElement.Schema;
                 case OpenApiConstants.Examples when mapKey != null:
                     return headerElement.Examples[mapKey];
                 default:
@@ -76,8 +74,6 @@ private static IOpenApiReferenceable ResolveReferenceOnParameterElement(
         {
             switch (propertyName)
             {
-                case OpenApiConstants.Schema:
-                    return (IOpenApiReferenceable)parameterElement.Schema;
                 case OpenApiConstants.Examples when mapKey != null:
                     return parameterElement.Examples[mapKey];
                 default:

test/Microsoft.OpenApi.Readers.Tests/V3Tests/JsonSchemaTests.cs

@@ -50,53 +50,7 @@ public void ParsePrimitiveSchemaShouldSucceed()
                         .Format("email")
                         .Build());
             }
-        }
-
-        [Fact]
-        public void ParsePrimitiveSchemaFragmentShouldSucceed()
-        {
-            using (var stream = Resources.GetStream(Path.Combine(SampleFolderPath, "primitiveSchema.yaml")))
-            {
-                var reader = new OpenApiStreamReader();
-                var diagnostic = new OpenApiDiagnostic();
-
-                // Act
-                //var schema = reader.ReadFragment<JsonSchema>(stream, OpenApiSpecVersion.OpenApi3_0, out diagnostic);
-
-                //// Assert
-                //diagnostic.Should().BeEquivalentTo(new OpenApiDiagnostic());
-
-                //schema.Should().BeEquivalentTo(
-                //    new JsonSchemaBuilder()
-                //        .Type(SchemaValueType.String)
-                //        .Format("email"));
-            }
-        }
-
-        [Fact]
-        public void ParsePrimitiveStringSchemaFragmentShouldSucceed()
-        {
-            var input = @"
-{ ""type"": ""integer"",
-""format"": ""int64"",
-""default"": 88
-}
-";
-            var reader = new OpenApiStringReader();
-            var diagnostic = new OpenApiDiagnostic();
-
-            // Act
-            //var schema = reader.ReadFragment<JsonSchema>(input, OpenApiSpecVersion.OpenApi3_0, out diagnostic);
-
-            //// Assert
-            //diagnostic.Should().BeEquivalentTo(new OpenApiDiagnostic());
-
-            //schema.Should().BeEquivalentTo(
-            //    new JsonSchemaBuilder()
-            //            .Type(SchemaValueType.Integer)
-            //            .Format("int64")
-            //            .Default(88), options => options.IgnoringCyclicReferences());
-        }
+        }       
 
         [Fact]
         public void ParseExampleStringFragmentShouldSucceed()