More smells

Author: darrelmiller

src/Microsoft.OpenApi.Hidi/Formatters/PowerShellFormatter.cs

@@ -23,15 +23,15 @@ internal class PowerShellFormatter : OpenApiVisitorBase
         static PowerShellFormatter()
         {
             // Add singularization exclusions.
-            // TODO: Read exclusions from a user provided file.
+            // Enhancement: Read exclusions from a user provided file.
             Vocabularies.Default.AddSingular("(drive)s$", "$1"); // drives does not properly singularize to drive.               
             Vocabularies.Default.AddSingular("(data)$", "$1"); // exclude the following from singularization.
             Vocabularies.Default.AddSingular("(delta)$", "$1");
             Vocabularies.Default.AddSingular("(quota)$", "$1");
             Vocabularies.Default.AddSingular("(statistics)$", "$1");
         }
 
-        //TODO: FHL taks for PS
+        //FHL task for PS
         // Fixes (Order matters):
         // 1. Singularize operationId operationIdSegments.
         // 2. Add '_' to verb in an operationId.
@@ -64,7 +64,7 @@ public override void Visit(OpenApiPathItem pathItem)
         public override void Visit(OpenApiOperation operation)
         {
             if (string.IsNullOrWhiteSpace(operation.OperationId))
-                throw new ArgumentException(nameof(operation), $"OperationId is required {PathString}");
+                throw new ArgumentException($"OperationId is required {PathString}", nameof(operation));
 
             var operationId = operation.OperationId;
             var operationTypeExtension = operation.Extensions.GetExtension("x-ms-docs-operation-type");
@@ -128,7 +128,7 @@ private static string SingularizeAndDeduplicateOperationId(IList<string> operati
 
                 // If a segment name is contained in the previous segment, the latter is considered a duplicate.
                 // The last segment is ignored as a rule.
-                if ((x > 0 && x < lastSegmentIndex) && singularizedSegments.Last().Equals(segment, StringComparison.OrdinalIgnoreCase))
+                if ((x > 0 && x < lastSegmentIndex) && singularizedSegments[singularizedSegments.Count - 1].Equals(segment, StringComparison.OrdinalIgnoreCase))
                     continue;
 
                 singularizedSegments.Add(segment);

src/Microsoft.OpenApi.Hidi/OpenApiService.cs

@@ -723,6 +723,7 @@ internal async static Task PluginManifest(HidiOptions options, ILogger logger, C
                 }
                 var slicedOpenApi = new FileInfo(Path.Combine(options.OutputFolder,"openapi.json"));
                 // Write OpenAPI to Output folder
+                options.Output = slicedOpenApi;
                 options.TerseOutput =true;
                 WriteOpenApi(options, OpenApiFormat.Json, OpenApiSpecVersion.OpenApi3_0, document, logger);