Skip to content

Fix: Remove minimatch pattern to sign all assemblies #1800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Fix: Remove minimatch pattern to sign all assemblies #1800

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a2f20e
Remove explicit pattern signature to enable signing of all binaries
MaggieKimani1 Aug 29, 2024
cfc69ca
Add display names
MaggieKimani1 Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .azure-pipelines/ci-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ extends:
arguments: '--configuration $(BuildConfiguration) --no-build'

- task: EsrpCodeSigning@5
displayName: 'ESRP CodeSigning binaries'
inputs:
ConnectedServiceName: 'Federated DevX ESRP Managed Identity Connection'
AppRegistrationClientId: '65035b7f-7357-4f29-bf25-c5ee5c3949f8'
Expand All @@ -87,8 +88,6 @@ extends:
AuthCertName: 'ReferenceLibraryPrivateCert'
AuthSignCertName: 'ReferencePackagePublisherCertificate'
FolderPath: '$(Build.SourcesDirectory)\src'
Pattern: '*.dll'
UseMinimatch: true
signConfigType: 'inlineSignParams'
inlineOperation: |
[
Expand Down Expand Up @@ -146,6 +145,7 @@ extends:
displayName: 'pack Hidi'

- task: EsrpCodeSigning@5
displayName: 'ESRP CodeSigning Nuget Packages'
inputs:
ConnectedServiceName: 'Federated DevX ESRP Managed Identity Connection'
AppRegistrationClientId: '65035b7f-7357-4f29-bf25-c5ee5c3949f8'
Expand Down
Loading