Skip to content

Conversation

@MaggieKimani1
Copy link
Contributor

Fixes #1970

UnresolvedReference = schema?.UnresolvedReference ?? UnresolvedReference;
Reference = schema?.Reference != null ? new(schema?.Reference) : null;
Annotations = schema?.Annotations != null ? new Dictionary<string, object>(schema?.Annotations) : null;
UnrecognizedKeywords = schema?.UnrecognizedKeywords != null ? new Dictionary<string, JsonNode>(schema?.UnrecognizedKeywords) : null;

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.
@baywet baywet self-requested a review as a code owner December 19, 2024 12:17
@baywet baywet enabled auto-merge December 19, 2024 12:22
Pattern = schema?.Pattern ?? Pattern;
MultipleOf = schema?.MultipleOf ?? MultipleOf;
_default = schema?.Default != null ? JsonNodeCloneHelper.Clone(schema?.Default) : null;
Default = schema?.Default != null ? JsonNodeCloneHelper.Clone(schema?.Default) : null;

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.
Discriminator = schema?.Discriminator != null ? new(schema?.Discriminator) : null;
_example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
_examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;
Example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.
_example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
_examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;
Example = schema?.Example != null ? JsonNodeCloneHelper.Clone(schema?.Example) : null;
Examples = schema?.Examples != null ? new List<JsonNode>(schema.Examples) : null;

Check warning

Code scanning / CodeQL

Virtual call in constructor or destructor Warning

Avoid virtual calls in a constructor or destructor.
@baywet baywet merged commit 8bf3fbe into vnext Dec 19, 2024
7 checks passed
@baywet baywet deleted the mk/support-unrecognized-keywords branch December 19, 2024 12:25
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

ooprala pushed a commit to VitaliyKurokhtin/OpenAPI.NET that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[API Review] : Implement support for handling unrecognized keywords in the OpenAPISchema

2 participants