fixes OpenAPI v2 request body parameter references serialization #2083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
baywet
requested review from
MaggieKimani1,
darrelmiller,
gavinbarron,
irvinesunday and
millicentachieng
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+126
to
+133
| if (writer.GetSettings().ShouldInlineReference(_reference)) | ||
| { | ||
| return Target.ConvertToBodyParameter(writer); | ||
| } | ||
| else | ||
| { | ||
| return new OpenApiParameterReference(_reference.Id, _reference.HostDocument); | ||
| } |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
|
baywet
changed the title
MaggieKimani1
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a bug where OpenAPI v2 body parameter references would not serialize properly and always inline the definition