Skip to content

Conversation

@baywet
Copy link
Member

@baywet baywet commented Feb 3, 2025

review #2112 first

@baywet baywet force-pushed the fix/no-more-nullable-property branch from 3cca210 to 4d9c17b Compare February 3, 2025 19:58
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
72.5% Coverage on New Code (required ≥ 80%)
3.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Base automatically changed from fix/nullable-down-cast-3-0 to dev February 4, 2025 06:28
Copy link
Contributor

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate the cleanup here 👍🏼

@andrueastman andrueastman merged commit 4821b92 into dev Feb 4, 2025
13 of 14 checks passed
@andrueastman andrueastman deleted the fix/no-more-nullable-property branch February 4, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants