Skip to content

Remove dependency on CurrentCulture in tests #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Remove dependency on CurrentCulture in tests #2118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions test/Microsoft.OpenApi.Tests/Writers/OpenApiWriterAnyExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ public async Task WriteOpenApiFloatAsJsonWorksAsync(float input, bool produceTer
var json = await WriteAsJsonAsync(floatValue, produceTerseOutput);

// Assert
Assert.Equal(input.ToString(), json);
Assert.Equal(input.ToString(CultureInfo.InvariantCulture), json);
}

public static IEnumerable<object[]> DoubleInputs
Expand Down Expand Up @@ -141,15 +141,15 @@ public async Task WriteOpenApiDoubleAsJsonWorksAsync(double input, bool produceT
var json = await WriteAsJsonAsync(doubleValue, produceTerseOutput);

// Assert
Assert.Equal(input.ToString(), json);
Assert.Equal(input.ToString(CultureInfo.InvariantCulture), json);
}

public static IEnumerable<object[]> StringifiedDateTimes
{
get
{
return
from input in new [] {
from input in new[] {
"2017-1-2",
"1999-01-02T12:10:22",
"1999-01-03",
Expand Down Expand Up @@ -178,7 +178,7 @@ public async Task WriteOpenApiDateTimeAsJsonWorksAsync(string inputString, bool
public static IEnumerable<object[]> BooleanInputs
{
get =>
from input in new [] { true, false }
from input in new[] { true, false }
from shouldBeTerse in shouldProduceTerseOutputValues
select new object[] { input, shouldBeTerse };
}
Expand Down Expand Up @@ -258,7 +258,7 @@ private static async Task<string> WriteAsJsonAsync(JsonNode any, bool produceTer
// Arrange (continued)
using var stream = new MemoryStream();
var writer = new OpenApiJsonWriter(
new StreamWriter(stream),
new CultureInvariantStreamWriter(stream),
new() { Terse = produceTerseOutput });

writer.WriteAny(any);
Expand All @@ -279,5 +279,15 @@ private static async Task<string> WriteAsJsonAsync(JsonNode any, bool produceTer
_ => value.MakeLineBreaksEnvironmentNeutral(),
};
}

private class CultureInvariantStreamWriter : StreamWriter
{
public CultureInvariantStreamWriter(Stream stream) : base(stream)
{
}

public override IFormatProvider FormatProvider => CultureInfo.InvariantCulture;
}

}
}