Skip to content

Conversation

Michael-Wamae
Copy link
Contributor

@Michael-Wamae Michael-Wamae commented Feb 19, 2025

  • feat: add support for dependentRequired
  • doc: update Public API
  • chore: remove unused function

Fixes #2123

Add support for dependentRequired validation keyword from JSON Schema Specification
Update the current API surface
Removed unused function and update Public API
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! a few comments

baywet and others added 8 commits February 19, 2025 07:59
Resolve reliance on reflection
Add support for dependentRequired validation keyword from JSON Schema Specification
Update the current API surface
Removed unused function and update Public API
Resolve reliance on reflection
…ired' into mw/add-support-for-dependentRequired
@Michael-Wamae Michael-Wamae changed the title Add support for dependentRequired feat: add support for dependentRequired Feb 20, 2025
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
66.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@baywet
Copy link
Member

baywet commented Feb 20, 2025

@Michael-Wamae please make sure you squash merge with a conventional commit so we have a clean entry in the changelog

@Michael-Wamae Michael-Wamae merged commit 75d7a66 into main Feb 20, 2025
14 of 15 checks passed
@Michael-Wamae Michael-Wamae deleted the mw/add-support-for-dependentRequired branch February 20, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v2 - lacks support for dependentRequired valdition keyword from JSON Schema Specification

3 participants