Skip to content

Conversation

Michael-Wamae
Copy link
Contributor

feat: use http method object instead of enum

Fixes #2068

@Michael-Wamae Michael-Wamae changed the title Mw/use http method object instead of enum feat: use http method object instead of enum Mar 13, 2025
baywet
baywet previously approved these changes Mar 13, 2025
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here!

@baywet baywet enabled auto-merge March 13, 2025 19:12
@baywet baywet disabled auto-merge March 13, 2025 19:13
@baywet baywet enabled auto-merge March 13, 2025 19:13
@baywet baywet merged commit 8baff28 into main Mar 13, 2025
10 of 13 checks passed
@baywet baywet deleted the mw/use-http-method-object-instead-of-enum branch March 13, 2025 19:14
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v2 consider making http method string constants instead of an enum

2 participants