Skip to content

Conversation

StefanCuypers
Copy link
Contributor

When parsing the list of tags, removed tags that are empty so we don't fail on them.

@StefanCuypers
Copy link
Contributor Author

@microsoft-github-policy-service agree

@MaggieKimani1
Copy link
Contributor

MaggieKimani1 commented Mar 27, 2025

Hi @StefanCuypers, thank you for your contribution!
Do you mind adding another commit that conforms to the Conventional commits standard?
We use the commit messages to trigger releases and update the changelog.

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Here are a couple of recommendations.

@MaggieKimani1 don't worry about the conventional commits just yet, we'll squash merge and amend the commit message as we do so

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@baywet baywet linked an issue Mar 28, 2025 that may be closed by this pull request
@baywet baywet enabled auto-merge (squash) March 28, 2025 12:22
@baywet baywet merged commit 521d636 into microsoft:main Mar 28, 2025
8 checks passed
@StefanCuypers StefanCuypers deleted the ignore-empty-tags branch March 28, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Empty tag causes error generating client

3 participants